bot_write_tab_customize: rearrange and style items in the write tab

floodfish · 2012-01-31 20:03:17

Thanks so much—whenever you get a chance, it’d be very helpful!

redbot · 2012-02-01 22:53:00

Hi Jason,
I’ve just made a quick diff between version 6.2 and 7 without too much investigation and I think you have to change these lines.
Around line 658 replace this:

// updates static sections prefs
$static_sections_string = $static_sections ? implode('|', $static_sections) : '';
safe_update('txp_prefs', 'val= "'.$static_sections_string.'", html="text_input" ', 'name = "bot_wtc_static_sections"' );
// updates script prefs
safe_update('txp_prefs', 'val= \''.doslash($bot_wtc_script).'\', html=\'textarea\' ', 'name = \'bot_wtc_script\'' );

with this:

// updates static sections prefs
if ($static_sections) {
        $static_sections_string = implode('|', $static_sections);
	safe_update('txp_prefs', 'val= "'.$static_sections_string.'", html="text_input" ', 'name = "bot_wtc_static_sections"' );
}
// updates script prefs
if ($bot_wtc_script) {
 	safe_update('txp_prefs', 'val= \''.doslash($bot_wtc_script).'\', html=\'textarea\' ', 'name = \'bot_wtc_script\'' );
}

This should do the trick (and incidentally it fixes another bug regarding the ‘js’ box). Let me know if it solves the issue.

floodfish · 2012-02-02 00:59:50

Thanks, redbot.

Didn’t work unfortunately. It remembers the checkbox settings for the first 21 sections, but none thereafter.

For whatever it’s worth, I’ve uninstalled and reinstalled the plugin and also deleted and rebuilt the database table.

philwareham · 2012-02-02 09:09:01

floodfish wrote:

It remembers the checkbox settings for the first 21 sections, but none thereafter.

Is that maybe to do with the 255 character limit on the database row for bot_wtc ‘sections’ field. Change it’s type from VARCHAR 255 to TEXT and see if that helps.

redbot · 2012-02-02 10:12:30

floodfish wrote:

…I am running into the hidden sections not sticking problem …

I was about to give the same advice as Phil (BTW thanks for helping) but now I have a doubt: are you talking about the “Hide sections in sections dropdown” field or the “hide in” field?
In the first case there should be no such issue given that the plugin uses the standard textpattern prefs table for this field (and the “val” column is already set to “text”).
In the other case Phil is right but then my fix above is useless since it deals with the “Hide sections in sections dropdown” field.
The only thing that come to mind is are you sure you are using txp 4.2 and not a previous version (‘val’ column in ‘prefs’ table was changed from’varchar’ to ‘text’ in txp 4.2 )?

Last edited by redbot (2012-02-02 11:38:44)

floodfish · 2012-02-02 16:55:13

Phil’s suggestion fixed it!

Big thanks to both of you. And this really is a very useful plugin.

Last edited by floodfish (2012-02-02 16:55:33)

mrdale · 2012-02-15 16:55:14

When you fix the save issue, the plugin will not hide multi-select and checkbox custom fields. Can we come up with a solution to that, it’s really frustrating.

(please, oh please)

redbot · 2012-02-15 22:51:50

Dale, for sure you don’t lack in concision but I’m still not telepathic ;)

so:

1) which “save issue” are you referring to? Maybe the one mentioned by Jason above? In this case it deals with an older version of the plugin and an older txp version so I may only suggest you to upgrade.

2) are you referring to the infamous suhosin module issue? In this case I fear I can do nothing since it is up to you to change your server settings (Maniqui shows how in the post I linked to).

3) You are talking about something totally different that I don’t get? Probably. In this last case can you be just a little more verbose?

mrdale · 2012-02-20 16:56:12

redbot wrote:
1) Maybe the one mentioned by Jason above?

nope

2) are you referring to the infamous suhosin module issue?

nope

3) You are talking about something totally different that I don’t get? Probably.

YES! Sorry for the confusion, I have a habit of starting to write up issues and then randomly cleaning out my garage.

Here’s the scoop.

I’m using glz_custom_fields with this plugin (0.7.1).

When I apply the hack that allows multi-selects and checkboxen to work, I still have an issue with those items not being hidden. On saving bot_wtc prefs it throws these errors…

Warning: You have an error in your SQL syntax; ... update bot_wtc set sections = 'section-a|section-b|section-c' where item = '$("p:has(*[name='custom_17'])")' in a/directory/txplib_db.php on line 89

Warning: You have an error in your SQL syntax; ... insert into bot_wtc set item = '$("p:has(*[name='custom_17'])")', sections ='section-a|section-b|section-c' a/directory/txplib_db.php on line 89

Last edited by mrdale (2012-02-20 16:59:07)

redbot · 2012-02-20 18:23:42

mrdale wrote:

…When I apply the hack that allows multi-selects and checkboxen to work, I still have an issue with those items not being hidden. On saving bot_wtc prefs it throws these errors…

This is so strange, needless to say it works ok for me, it looks like for some reason it doesn’t recognize multiselects and checkboxes at all, which of course shouldn’t happen.

A few questions/suggestions:

You say “When I apply the hack that allows…” but which hack are you referring to? You shouldn’t need to apply any hack if you are using the latest version (0.7.1)
Maybe it has to do with some values stored in the db which were created with an older version of the plugin? It shouldn’t be but, just to be sure, have you tried to delete and recreate only the rules you are having issues with?
Another ~~desperate~~ suggestion is to try to install the plugin again (without uninstalling it – if you want to keep your already saved rules) as v. 7.0.1 should automatically emend any legacy data stored in the db

Let me know if some of these works (of course it won’t)

Last edited by redbot (2012-02-20 18:24:41)

mrdale · 2012-02-21 01:08:02

deleted plugin prefs
deleted bot_wtc
reinstalled 0.7.1

On first turning on plugin …

alter table bot_wtc CHANGE sections sections TEXT Warning: Table 'my_db.bot_wtc' doesn't exist alter table bot_wtc CHANGE sections sections TEXT in /a/directory/textpattern/lib/txplib_db.php on line 89

.p thereafter saving advanced prefs for any field

Warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'custom_2'])")'' at line 1 update bot_wtc set sections = 'about-us|club|contact|default|events|general|news|newsletter|store|vineyards' where item = '$("p:has(*[name='custom_2'])")' in /a/dir/textpattern/lib/txplib_db.php on line 89

Warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'custom_2'])")', sections = 'about-us|club|contact|default|events|general|news|ne' at line 1 insert into bot_wtc set item = '$("p:has(*[name='custom_2'])")', sections = 'about-us|club|contact|default|events|general|news|newsletter|store|vineyards' in /a/dir/textpattern/lib/txplib_db.php on line 89

redbot · 2012-02-21 14:21:18

Eeek! I think now I have an idea what could be wrong, I’ll try to fix it asap (not in the next 48 hours I fear since I can’t even access my computer).

For now – if you like to help testing – you can try this:
around line 647 change

"item = '".$item."'"

to:

"item = '".doslash($item)."'"

Does it fix at least the save issue?

Textpattern CMS

Textpattern CMS support forum

#253 2012-01-31 20:03:17

Re: bot_write_tab_customize: rearrange and style items in the write tab

#254 2012-02-01 22:53:00

Re: bot_write_tab_customize: rearrange and style items in the write tab

#255 2012-02-02 00:59:50

Re: bot_write_tab_customize: rearrange and style items in the write tab

#256 2012-02-02 09:09:01

Re: bot_write_tab_customize: rearrange and style items in the write tab

#257 2012-02-02 10:12:30

Re: bot_write_tab_customize: rearrange and style items in the write tab

#258 2012-02-02 16:55:13

Re: bot_write_tab_customize: rearrange and style items in the write tab

#259 2012-02-15 16:55:14

Re: bot_write_tab_customize: rearrange and style items in the write tab

#260 2012-02-15 22:51:50

Re: bot_write_tab_customize: rearrange and style items in the write tab

#261 2012-02-20 16:56:12

Re: bot_write_tab_customize: rearrange and style items in the write tab

#262 2012-02-20 18:23:42

Re: bot_write_tab_customize: rearrange and style items in the write tab

#263 2012-02-21 01:08:02

Re: bot_write_tab_customize: rearrange and style items in the write tab

#264 2012-02-21 14:21:18

Re: bot_write_tab_customize: rearrange and style items in the write tab

Board footer