Textpattern CMS support forum

You are not logged in. Register | Login | Help

#41 2009-09-15 22:35:21

truist
Plugin Author
From: Ohio, USA
Registered: 2004-11-09
Posts: 256
Website

Re: mem_postmaster - Postmaster Revamp

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

Offline

#42 2009-09-16 00:00:14

Gocom
Plugin Author
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,530
Website

Re: mem_postmaster - Postmaster Revamp

truist wrote:

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

You are redeclaring pref_func(). Pref_func() is a core function, defined in txp_prefs.php. But, in your plugin you have a line:

include(txpath . '/include/txp_prefs.php');

Which will cause conflicts with any plugin which includes the same file on same page load. To fix this, you can possibly, either use function check, class or include_once.

Offline

#43 2009-09-16 00:08:08

truist
Plugin Author
From: Ohio, USA
Registered: 2004-11-09
Posts: 256
Website

Re: mem_postmaster - Postmaster Revamp

Ah, that makes sense. I will fix this in the next version of tru_tags. Thank you!

Offline

#44 2009-09-16 00:29:47

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

You also don’t want to include it when $event == ‘prefs’, since for some reason the core didn’t feel like using the *_once functions in ./textpattern/index.php.

Offline

#45 2009-09-16 05:08:00

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,245
Website

Re: mem_postmaster - Postmaster Revamp

michael, The update seemed to have worked and the error disappeared.


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | Respbublika! | NeMe @ github

Offline

#46 2009-09-16 11:48:41

candyman
Member
From: Italy
Registered: 2006-08-08
Posts: 684

Re: mem_postmaster - Postmaster Revamp

truist wrote:

Manfre, someone (colak?) alerted me to this problem

It was me.
I agree with colak: the problem was solved with the latest mem_postmaster patch.

Offline

#47 2009-09-16 15:10:36

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,245
Website

Re: mem_postmaster - Postmaster Revamp

I so much apologise about thsi but I think that I hit another bug.

On the “Editing List: ABCtab the forms are not recognised. What I get is a pull-down menu with nothing in it. (it is only a few pixels wide). This means that I cannot allocate a form to any new lists.

I have 2 article forms named

  • postmaster
  • postmaster-default

The existing lists, (Total Lists subtab) indicate the name of the form but when I click to edit the list, nothing appears in the pull down menu.


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | Respbublika! | NeMe @ github

Offline

#48 2009-09-16 15:14:57

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

colak wrote:

From first post:

List Form _New Feature: Select autopopulates with all forms that begin with “newsletter-” or another string you select _

rename your forms so that they begin with newsletter- and they will appear in the list.

Offline

#49 2009-09-16 15:27:30

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,245
Website

Re: mem_postmaster - Postmaster Revamp

Once again I feel like an idiot!

Works just fine now:)

many many thanks michael

Last edited by colak (2009-09-16 15:27:53)


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | Respbublika! | NeMe @ github

Offline

#50 2009-09-17 07:28:07

mlarino
Member
Registered: 2007-06-29
Posts: 367

Re: mem_postmaster - Postmaster Revamp

Is there anything under the preferences tab?
I click on preferences and I get a blank page with a “save” button. (just that)

using 4.0.2 and tru_tags

Last edited by mlarino (2009-09-17 07:28:29)

Offline

Board footer

Powered by FluxBB