Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#37 2009-09-15 07:48:34

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,037
Website GitHub Mastodon Twitter

Re: mem_postmaster - Postmaster Revamp

candyman wrote:

It seems that the latest version of mem_postmaster causes conflicts with some others plugins option menu in the Extensions panel.

After activating the plugin (not the library), in my case (TXP 4.0.8), the

  • rss_admin_db_manager (DB backup menu)

confirmed.

Error in the page:

Fatal error: Cannot redeclare pref_func() (previously declared in /users/home/xxx/web/public/textpattern/lib/txplib_misc.php(594) : eval()'d code:901) in /users/home/xxx/web/public/textpattern/include/txp_prefs.php on line 244

Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#38 2009-09-15 14:04:56

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

@candyman, change the plugin load order so that mem_postmaster is after all of those other plugins.

Offline

#39 2009-09-15 15:01:41

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,037
Website GitHub Mastodon Twitter

Re: mem_postmaster - Postmaster Revamp

Hi Michael
I have changed the plugin’s load order to ‘9’ using plugin composer but the error does not go away.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#40 2009-09-15 15:32:31

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

v1.0.5
  • Renamed pref_func().

The problem was caused by many plugins needing to redefine a core function and the other plugins did not properly guard with a function_exists() check. You should contact the plugin authors to get them to properly guard their code.

Offline

#41 2009-09-15 22:35:21

truist
Plugin Author
From: Ohio, USA
Registered: 2004-11-09
Posts: 257
Website

Re: mem_postmaster - Postmaster Revamp

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

Offline

#42 2009-09-16 00:00:14

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: mem_postmaster - Postmaster Revamp

truist wrote:

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

You are redeclaring pref_func(). Pref_func() is a core function, defined in txp_prefs.php. But, in your plugin you have a line:

include(txpath . '/include/txp_prefs.php');

Which will cause conflicts with any plugin which includes the same file on same page load. To fix this, you can possibly, either use function check, class or include_once.

Offline

#43 2009-09-16 00:08:08

truist
Plugin Author
From: Ohio, USA
Registered: 2004-11-09
Posts: 257
Website

Re: mem_postmaster - Postmaster Revamp

Ah, that makes sense. I will fix this in the next version of tru_tags. Thank you!

Offline

#44 2009-09-16 00:29:47

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

You also don’t want to include it when $event == ‘prefs’, since for some reason the core didn’t feel like using the *_once functions in ./textpattern/index.php.

Offline

#45 2009-09-16 05:08:00

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,037
Website GitHub Mastodon Twitter

Re: mem_postmaster - Postmaster Revamp

michael, The update seemed to have worked and the error disappeared.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#46 2009-09-16 11:48:41

candyman
Member
From: Italy
Registered: 2006-08-08
Posts: 684

Re: mem_postmaster - Postmaster Revamp

truist wrote:

Manfre, someone (colak?) alerted me to this problem

It was me.
I agree with colak: the problem was solved with the latest mem_postmaster patch.

Offline

#47 2009-09-16 15:10:36

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,037
Website GitHub Mastodon Twitter

Re: mem_postmaster - Postmaster Revamp

I so much apologise about thsi but I think that I hit another bug.

On the “Editing List: ABCtab the forms are not recognised. What I get is a pull-down menu with nothing in it. (it is only a few pixels wide). This means that I cannot allocate a form to any new lists.

I have 2 article forms named

  • postmaster
  • postmaster-default

The existing lists, (Total Lists subtab) indicate the name of the form but when I click to edit the list, nothing appears in the pull down menu.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#48 2009-09-16 15:14:57

Manfre
Plugin Author
From: North Carolina
Registered: 2004-05-22
Posts: 588
Website

Re: mem_postmaster - Postmaster Revamp

colak wrote:

From first post:

List Form _New Feature: Select autopopulates with all forms that begin with “newsletter-” or another string you select _

rename your forms so that they begin with newsletter- and they will appear in the list.

Offline

Board footer

Powered by FluxBB