Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#37 2008-06-28 07:09:56

joel
Member
Registered: 2004-11-26
Posts: 162

Re: jmd_img_selector: Thickbox-style image selector

It would be nice to be able to set a image class for the selected image next to the image-type-dropdown. Is that possible?

Offline

#38 2008-06-28 19:38:53

masa
Member
From: Asturias, Spain
Registered: 2005-11-25
Posts: 1,091

Re: jmd_img_selector: Thickbox-style image selector

joel wrote:

It would be nice to be able to set a image class for the selected image next to the image-type-dropdown. Is that possible?

Probably, although I have a feeling that we would be deviating too much from the original idea of building a very simple image insertion tool

Let’s wait what jm thinks.

Offline

#39 2008-07-01 10:24:08

jm
Plugin Author
From: Missoula, MT
Registered: 2005-11-27
Posts: 1,746
Website

Re: jmd_img_selector: Thickbox-style image selector

joel wrote:

It would be nice to be able to set a image class for the selected image next to the image-type-dropdown. Is that possible?

It’s possible, but it’s not something I want to add because it would increase the complexity of the plugin and clutter the interface. Like Martin said, it is meant to be a simple image selector.

Offline

#40 2008-07-01 14:36:46

renobird
Member
From: Gainesville, Florida
Registered: 2005-03-02
Posts: 786
Website

Re: jmd_img_selector: Thickbox-style image selector

jm,

Just upgraded from 0.1 to 0.2a – I haven’t changed anything except the plugin – and I’m getting

• thickbox.css not found
• thickbox.js not found

The path is set correctly in the EXTENSIONS tab.

Any ideas?

EDIT

Just saw this mentioned a dozen posts back or so.
Is there a fix – or should I just stick with 0.1 for now?

Sorry for re-posting a known issue. doh!

Last edited by renobird (2008-07-01 14:39:58)

Offline

#41 2008-07-01 16:25:12

jm
Plugin Author
From: Missoula, MT
Registered: 2005-11-27
Posts: 1,746
Website

Re: jmd_img_selector: Thickbox-style image selector

Well, the fix would be to remove my retarded file-checking code :). It’s incorrect, so it’s safe to ignore.

0.2 still needs a little more work, but I think I can get a release out before Friday.

Offline

#42 2008-07-01 16:30:02

renobird
Member
From: Gainesville, Florida
Registered: 2005-03-02
Posts: 786
Website

Re: jmd_img_selector: Thickbox-style image selector

Jm,

Thanks. I’ll just hang tight. v0.1 got me through today.
Looking forward to the next release.


Tom

Offline

#43 2008-07-07 00:18:04

jm
Plugin Author
From: Missoula, MT
Registered: 2005-11-27
Posts: 1,746
Website

Re: jmd_img_selector: Thickbox-style image selector

The last article-image only release, 0.2, is finally up.

Last edited by jm (2008-07-07 00:28:24)

Offline

#44 2008-07-07 00:56:32

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,215
Website

Re: jmd_img_selector: Thickbox-style image selector

Su-weet, couple of things.

  1. image Thumbs would make the page load light-years faster.
  2. “Close” needs to be more obvious
  3. I think the hover and selected behaviour should be the same by default in the base style.
  4. [edit] also an “Image name:” prefic to the name would be nice.

Apart from that, I give 2 a solid “yabba-dabba-deux”

[edit] for some reason the little piece of code to detect the presence of thumbnail was not working, but when I hard coded it by removing the “if” I noticed that thumbs work very fast… nice.

_[edit #2] nice touch that you removed thickbox dependency.

Last edited by mrdale (2008-07-07 01:09:16)

Offline

#45 2008-07-07 01:16:25

jm
Plugin Author
From: Missoula, MT
Registered: 2005-11-27
Posts: 1,746
Website

Re: jmd_img_selector: Thickbox-style image selector

  1. Strange. The conditional works on my local 4.0.7 and live 4.0.6 installs.
  2. I’ll add a header similar to the original Thickbox.
  3. How about a not-quite-selected state? Like #jmdImgSel_images li:hover { border-color: #999 }
  4. I’ll drop the image name onto its own line – it might be a little clearer then.

Offline

#46 2008-07-07 01:28:27

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,215
Website

Re: jmd_img_selector: Thickbox-style image selector

  1. weird
  2. excellent
  3. excellent, although how about making it fully opaque.
  4. Nah, I’d leave it where it is for nice space usage, just do a “Name:”

not to be bossy or anything, LOL (actually I should say please and that you can take or leave my input)

Much thanks!

One quirk that is probably a TXP thing is that it takes me quite a bit of refreshing to get the selector to turn up… interesting.

Last edited by mrdale (2008-07-07 01:35:08)

Offline

#47 2008-07-07 01:58:32

jm
Plugin Author
From: Missoula, MT
Registered: 2005-11-27
Posts: 1,746
Website

Re: jmd_img_selector: Thickbox-style image selector

Haha well, “Name:” takes up horizontal space :). It’ll be modifiable via CSS (again – I’m lazy).

Somewhat crude CSS – 0.2.1 is now up. Not sure how to style the close button (or “Images added” msg).

One quirk that is probably a TXP thing is that it takes me quite a bit of refreshing to get the selector to turn up… interesting.

Does loading http://example.com/textpattern/?event=jmd_img_selector_thickbox work reliably? When you click the image selector link, it makes a request to that page, but when you close it, it just hides #jmdImgSel (and shows it the next time you click the link), so you won’t have to reload the page.

Last edited by jm (2008-07-07 02:03:49)

Offline

#48 2008-07-08 12:27:47

masa
Member
From: Asturias, Spain
Registered: 2005-11-25
Posts: 1,091

Re: jmd_img_selector: Thickbox-style image selector

I’m having a problem with 0.2.1 (and 0.2 before that): the picker appears, but is totally unstyled and therefore drops below the txp logo at the bottom.

I followed the installation instructions carefully, removed thickbox, created the css etc., but to no avail. Also FF’s error console shows no errors. I tried reinstalling, but no luck. 0.1 worked fine.

Any ideas?

Offline

Board footer

Powered by FluxBB