Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#796 2008-06-23 13:20:23

lee
Member
From: Normandy, France
Registered: 2004-06-17
Posts: 831

Re: MLP - The Multi-Lingual Publishing Pack

Looks very neat to me.

EDIT: Be cool if you could add in automatic translation :)

Last edited by lee (2008-06-23 13:23:41)

Offline

#797 2008-06-23 13:20:56

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

Stef, Lee

Thank you.

All

Any other opinions? Will it meet your needs?

Last edited by net-carver (2008-06-23 13:21:51)


Steve

Offline

#798 2008-06-23 13:37:08

beztak
Member
From: Czech Republic
Registered: 2005-07-21
Posts: 184
Website

Re: MLP - The Multi-Lingual Publishing Pack

net-carver wrote:

Any other opinions?

Maybe this was discussed before, but I don’t like this:

<txp:l10n_if_lang lang="cs-cz" wraptag="">xxx</txp:l10n_if_lang>

I don’t want to use wraptag, is so, I can add this atribut, but by default it should be:

<txp:l10n_if_lang lang="cs-cz">xxx</txp:l10n_if_lang>

and if I want some wraptag:

<txp:l10n_if_lang lang="cs-cz" wraptag="div">xxx</txp:l10n_if_lang>

Last edited by beztak (2008-06-23 13:37:25)

Offline

#799 2008-06-23 13:49:08

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

Jirka

Noted. Any opinion about the clone-all-from feature we were discussing?

Lee

Sounds like you need to get Stef on the job. Sure he can send me a patch for that.


Steve

Offline

#800 2008-06-23 13:57:09

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: MLP - The Multi-Lingual Publishing Pack

net-carver wrote:

Sounds like you need to get Stef on the job. Sure he can send me a patch for that.

:-) Je m’appelle Stef. Je suis un plugin-writer compliqué. Je suis desolé, mais je ne bon pas à Français :-D

Last edited by Bloke (2008-06-23 13:58:32)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#801 2008-06-23 14:26:22

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

Jirka

Check out item 028 here.

Lee (and others)

Check out item 029 in the same list.


Steve

Offline

#802 2008-06-23 19:38:44

ultramega
Member
Registered: 2006-02-26
Posts: 221

Re: MLP - The Multi-Lingual Publishing Pack

Simple and I think it should solve the major problem of quickly generating clones for translation. What do you all think?

Sounds perfect!

Offline

#803 2008-06-23 20:49:49

azw
Member
Registered: 2007-01-29
Posts: 279

Re: MLP - The Multi-Lingual Publishing Pack

That cloning compromise sounds good to me, Steve.

I like that it’ll sort out which ones don’t need to be cloned because they’re already present.

Yeah, and on the dreaming side, automatic translation sure would that make it all so much easier!

Offline

#804 2008-06-24 01:59:25

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

Folks

Ok, no negative feedback yet so that’ll be the next feature into the pack.

FYI : I’ve implemented beztak (Jirka)’s suggestion and l10n_if_lang now defaults to having a blank “wraptag” attribute. If you need the div wrapper you’ll have to edit your pages/forms to add it in once this new version gets released.

FYI : I have also — following a frustrating time helping Lee with a client site — decided to add an option to ignore the visitor’s browser’s accept-language headers when deciding what language to serve the site in. This should simplify things for development and debugging — and possibly running your site. But I think once you have a stable site with all languages populated then honouring the browser’s language prefs would be better for first-time site visitors.

Anyway, the option will be there for you. I’m sure this was requested previously in this thread somewhere — but I’m not going to search for it — so kudos to the original suggester(s), whoever you were.


Steve

Offline

#805 2008-06-24 02:56:18

maniqui
Member
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: MLP - The Multi-Lingual Publishing Pack

Hi Steve! Hold on! I’m just about to update, so if you can wait like… twenty minutes more, I will give some feedback.

FYI : I have also — following a frustrating time helping Lee with a client site — decided to add an option to ignore the visitor’s browser’s accept-language headers when deciding what language to serve the site in. This should simplify things for development and debugging — and possibly running your site. But I think once you have a stable site with all languages populated then honouring the browser’s language prefs would be better for first-time site visitors.

Anyway, the option will be there for you. I’m sure this was requested previously in this thread somewhere — but I’m not going to search for it — so kudos to the original suggester(s), whoever you were.

I think I didn’t understand this new feature.

Last edited by maniqui (2008-06-24 02:56:27)


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#806 2008-06-24 03:03:01

maniqui
Member
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: MLP - The Multi-Lingual Publishing Pack

net-carver wrote:

Anyway, the option will be there for you. I’m sure this was requested previously in this thread somewhere — but I’m not going to search for it — so kudos to the original suggester(s), whoever you were.

Are you talking about this posts: 1, 2?


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#807 2008-06-24 03:29:24

maniqui
Member
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: MLP - The Multi-Lingual Publishing Pack

OK, so far, so good.

I’ve updated a site (the one with MySQL < 4.1) and everything seems to be working fine :)

Steve, do you have any kind of checklist you want me to test?

BTW, I haven’t updated the txplib_db.php file, because I have done a manual diff sometime ago to merge your version and the version that comes with TXP 4.0.6.
Are there any changes in your version or can I keep my “merged” version?

Finally, should I install your library? Any advantage in having it installed?


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#808 2008-06-24 04:58:36

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

maniqui wrote:

Are you talking about this posts: 1, 2?

Looks about right. The new feature just allows your site to ignore whatever the user’s browser is sending as its preferred language . That’s useful in cases where the user hasn’t setup the browser prefs (as you pointed out) or where a developer wants to look at the site default but that isn’t what they normally have their browser setup for.

In Lee’s case, (I assume) he was using English as his preferred browse language but expected to see the site default of French when he visited the site.

I’ve updated a site (the one with MySQL < 4.1) and everything seems to be working fine :)

Steve, do you have any kind of checklist you want me to test?

Yes…

  1. Commenting (on different renditions of the same article.)
  2. Contact form.
  3. File downloads give you a valid file (no BOM corruption at the beginning.)
  4. Validation.
  5. Searching.
  6. Feeds (note the new feed preference on MLP>Prefs)
  7. Urls to have language marker inserted…
    1. Permalinks
    2. l10n_lang_list output
    3. Search result urls and displayed address
    4. When the xhtml has href="" , HREF="" , href='' , HREF='' (some of these used to fail)
    5. Even when the address is urlencoded (ie. with special characters like + for spaces)
    6. Even using messy mode
  8. No language marker in…
    1. Off-site links
    2. Admin side urls
    3. Linked css or js
    4. Images (like a thumb linked to a fullsize image)
    5. File downloads
    6. Any section/area listed in the mlp>prefs as excluded from rewrites

Will that do for now?

Are there any changes in your version (of txplib_db.php) or can I keep my “merged” version?

Yes, Stef asked the Dev’s to make a few changes for 4.0.7. In anticipation of that release, the new version of the file has the changes. You might want to do a manual diff and merge to check them for yourself. They should make no difference to users of 4.0.6.

Finally, should I install your library? Any advantage in having it installed?

It has a helper class in it (sed_mlp) that takes most of the hard work out of making other plugins MLP compatible. Thanks to Stef for the idea for that. If you aren’t using plugins that need it then no advantage installing it.


Steve

Offline

#809 2008-06-24 05:42:39

maniqui
Member
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: MLP - The Multi-Lingual Publishing Pack

net-carver wrote:

Commenting (on different renditions of the same article.)

Sorry, can’t test them: no comments on this site.

Contact form.

I’ve tested sending an email from each translated contact form (en, es). It seems to have worked fine. My client should send me a reply tomorrow telling me she received the emails.

File downloads give you a valid file (no BOM corruption at the beginning.)

Again, sorry, no file downloads.

Validation.

You mean validating the source on W3C? It seems to have worked fine.

Searching.

Seems to work as before, that is, fine, perfect.

Feeds (note the new feed preference on MLP>Prefs)

Not sure how to test this. In this site, the feeds are “per section”, and just for the news section.
You can take a look at the generated urls URLs here.

Urls to have language marker inserted…
Permalinks
l10n_lang_list output
Search result urls and displayed address

Seems to be working correctly.

When the xhtml has href="" , HREF="" , href='' , HREF='' (some of these used to fail)
Even when the address is urlencoded (ie. with special characters like + for spaces)
Even using messy mode

Haven’t tested.

No language marker in…
Off-site links
Admin side urls

Seems to work fine.

Linked css or js

Haven’t tested because there isn’t any static js/css linked.

Images (like a thumb linked to a fullsize image)

Seems to work fine.

File downloads

Haven’t tested it: there isn’t any file to download.

Any section/area listed in the mlp>prefs as excluded from rewrites

Haven’t excluded any other section.

Will that do for now?

Yes, thanks.
I’ve another site with MLP but it’s under an slow development process. I will try to update that one too asap, and do more testing on this checklist.

Thanks again!


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#810 2008-06-24 17:18:17

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: MLP - The Multi-Lingual Publishing Pack

Julián

Thank you for taking some time to test the changes.


Steve

Offline

Board footer

Powered by FluxBB