Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#811 2020-03-11 19:22:15

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 8,270
Website

Re: tru_tags: A tagging plugin for textpattern

Vienuolis wrote #322167:

<meta::description format="" /> output disappear on sections after Textpattern 4.7.3 → 4.8.0 upgrade. No warnings while in debugging mode. And no changes on Meta description docs since v4.6.0.

Would the double colon be the reason? it should be: <meta:description format="" />


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | NeMe @ github | Covid-19; a resource
I do my best editing after I click on the submit button.

Offline

#812 2020-03-11 19:51:39

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 225
Website

Re: tru_tags: A tagging plugin for textpattern

Sorry, I know txp:meta_description or meta::description types only.

Offline

#813 2020-04-17 04:25:54

peterj
Member
From: Melbourne, Australia
Registered: 2005-06-02
Posts: 46

Re: tru_tags: A tagging plugin for textpattern

Try htaccess workaround – see Jakob’s rewrite rule here

Adapted:

# Temporary: tru_tags url rewrite
RewriteRule ^tag/(article/)?(.+)$ ?s=tag&t=$1@

Last edited by peterj (2020-04-19 04:02:17)

Offline

#814 2020-04-17 13:19:40

Vienuolis
Member
From: Vilnius, Lithuania
Registered: 2009-06-14
Posts: 225
Website

Re: tru_tags: A tagging plugin for textpattern

I am using Hiawatha webserver instead of Apache, so I changed this .htaccess string to the regular expression

Match ^/tag/(.+)/ Rewrite /index.php?s=tag&t=$1

and tagged links work now again as should. Thank you for the help!

Offline

#815 2020-06-23 10:26:39

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 272
Website

Re: tru_tags: A tagging plugin for textpattern

Bloke wrote #322056:

Nope, seems to be a bug in 4.8.0. I don’t think there’s anything that can be done in the plugin to fix this, because Txp is throwing out the URL before the plugin even has a chance to intervene. Same with smd_tags. We’ll have to figure this out in core. Sorry for the hassle.

Is this problem fixed in 4.8.1? Or do I still have to use a special rewrite rule?

Offline

#816 2020-06-23 10:28:07

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,724
Website

Re: tru_tags: A tagging plugin for textpattern

whocarez wrote #323929:

Is this problem fixed in 4.8.1? Or do I still have to use a special rewrite rule?

Should be fixed in 4.8.1 but you may still have to alter the plugin to load order 4 or lower.

EDIT: and any custom URLs you generate that target landing pages MUST end in a trailing slash or Txp might consider them articles. This behaviour depends on your per-section permlink setup, but to be safe, just include the trailing slash on non-article pages.

Last edited by Bloke (2020-06-23 10:30:16)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#817 2020-06-24 19:45:31

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 272
Website

Re: tru_tags: A tagging plugin for textpattern

After updating another installation without my own permanent link format, means with untouched files, I have to correct my answer from the release thread, . The bug is still present in 4.8.1.. Changing the load order, didn’t help.

For nginx I needed this rewriting rule:
rewrite ^/tag/(.+)/$ /index.php?s=tag&t=$1;

In the 4.8.1 installation where it works, I use my modified permalink format "title_id". And there I added for example in the chopUrl function in publish.php the line $req = preg_replace('/\_/', '/', $req);. Maybe that’s why it is working there.

Last edited by whocarez (2020-06-24 19:59:31)

Offline

#818 2020-06-24 21:01:03

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 9,724
Website

Re: tru_tags: A tagging plugin for textpattern

Hmmmm, what happens if you set the load order to 4 and mod the plugin as follows:

if (tru_tags_clean_urls()) {
	// register_callback('tru_tags_clean_url_handler', 'pretext');
	tru_tags_clean_url_handler();
}

function tru_tags_clean_url_handler($event = null, $step = null) {
...
}

The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#819 2020-06-24 21:28:11

whocarez
Plugin Author
From: Germany/Ukraine
Registered: 2007-10-08
Posts: 272
Website

Re: tru_tags: A tagging plugin for textpattern

It works, but only with an load order of at least 4 … Thanks!

Last edited by whocarez (2020-06-24 22:05:57)

Offline

#820 2020-06-24 22:04:25

etc
Developer
Registered: 2010-11-11
Posts: 3,869
Website

Re: tru_tags: A tagging plugin for textpattern

Probably, if your plugin sets global $pretext['s'] on pretext callback, the load order is not important (untested) not valid any more, sorry. Instead, if your plugin rewrites request_uri, you must set its load order < 5 and

register_callback('my_uri_rewrite', 'pretext', '', 1);

Last edited by etc (2020-06-25 12:07:34)

Offline

Board footer

Powered by FluxBB