Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
Please de-activate rss_suparchive and see if file-downloads work again after that. If that is the case, please contact Rob with a pointer to this thread/my post here.
The plugin hooks into pretext-callback and makes some changes to global-vars which (I am only guessing at this point) as a side-effect breaks file-downloads. I am sure the plugin can be fixed, such that it only makes those changes in the pretext-callback when it is really needed (i.e. when the plugin knows it will be handling those urls).
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
That is it Sencer. Disabling rss_suparchive allows file_download_link to work again. I need to make a note that when something goes wrong first disable all the plugins. I will notify Rob right away.
Last edited by tinyfly (2006-01-09 15:57:15)
Refresh Dallas and other Refreshing Cities.
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
> Sencer wrote:
The plugin hooks into pretext-callback and makes some changes to global-vars which (I am only guessing at this point) as a side-effect breaks file-downloads. I am sure the plugin can be fixed, such that it only makes those changes in the pretext-callback when it is really needed (i.e. when the plugin knows it will be handling those urls).
Yeah, that would seem to be the case. Is there a way that I can tell from that callback if the plugin will be called in one of the pages or forms that will handle the URL?
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
Yeah, that would seem to be the case. Is there a way that I can tell from that callback if the plugin will be called in one of the pages or forms that will handle the URL?
Ah, didn’t know it was dependant on tags.
At that point (pretext) it is not yet known which pages/forms will be parsed, so it’s not possible to do it that specific. I was thinking in more general terms to check if the first item is a valid section or something similar.
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
I was thinking in more general terms to check if the first item is a valid section or something similar.
That should work for now. But its seems that even if that fixes file downloads, its bound to break something else someday.
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
I posted version 0.16.1 that should fix the problem. I was able to test it out on 4.0.3 and my file downloads work.
Last edited by wilshire (2006-01-09 23:50:18)
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
wilshire and Sencer… thanks very much :)
Offline
Re: 4.0.3 r1188 txp:file_download_list problems [resolved, plugin-related]
In case you’re using zem_rewrite and are having similar troubles: watch out for your zem_rewrite rules (and order of said rules); if you have {article} (as in article id) involved in any of your rules, this can produce a false match when asking for /file_download/[id].
My clean url scheme is now completely functional with {section}, {category}, {year} and {url_title} matches, avoiding any conflicts with file ids. Here’s my file_download-friendly zem_rewrite pattern:
$uri_scheme[‘article_archive2’] = ‘{section}/{category}/{year}/{url_title}’;
$uri_scheme[‘article_archive’] = ‘{section}/{year}/{url_title}’;
$uri_scheme[‘article3’] = ‘{section}/{category}/{url_title}’;
$uri_scheme[‘category’] = ‘{section}/{category}/’;
$uri_scheme[‘section’] = ‘{section}/’;
$uri_scheme[‘article_alt2’] = ‘{section}/{url_title}’;
Last edited by simmerdesign (2006-11-22 16:30:03)
Offline