hak_tinymce WYSIWYG article editor

hakjoon · 2009-11-23 23:22:39

Ok I think I fixed those v. 0.9.3 . The zip will still say 0.9.2 (I need to reorganize the files), but the plugin should identify itself as 0.9.3

Last edited by hakjoon (2009-11-23 23:22:53)

beztak · 2009-11-24 08:34:25

It doesn’t work for me on txp4.2.0. I think there is one problem with brackets. In plugin on line 561 and 562 instead of this:

        $format .= (!empty($arr["alt"])) ? ',alt:"'.$arr["alt"] : '"';
        $format .= (!empty($arr["title"])) ? ',title:"'.$arr["title"] : '"';

should be this:

        $format .= (!empty($arr["alt"])) ? ',alt:"'.$arr["alt"].'"' : '';
        $format .= (!empty($arr["title"])) ? ',title:"'.$arr["title"].'"' : '';

Edit: ~~And another notice – toggle editor checkboxes doesn’t work as well.~~ (Looking that this collide with some of my other plugin)

Also there is some css problem with txpimage popup in IE7 (thumbnails has only one pixel width). I will look at it.

Last edited by beztak (2009-11-24 11:34:44)

beztak · 2009-11-24 08:55:36

And here is another bug: after clicking thumb icon it doesn’t change thumb’s dimensions. So on line 603 – 605:

	$props = @getimagesize($path_to_site.'/'.$thumb["path"]);
	$thumb["width"] = ($props[0]) ? $props[0] : "";
	$thumb["height"] = ($props[1]) ? $props[1] : "";

should be just this:

	$thumb["width"] = $thumb_w;
	$thumb["height"] = $thumb_h;

hakjoon · 2009-11-24 14:52:03

Thanks beztak. I appreciate the help. 0.9.5

Fixes the quoting issue (I hate concatenating strings to build html), and uses the new thumb dimensions form the db (didn’t realize those were in there now).

I’m not being able to replicate your issue with IE7. I’ll keep looking. I’m away for the rest of the week but keep reports coming.

Thanks for the help and patience.

Last edited by hakjoon (2009-11-24 14:52:57)

webspy · 2009-12-01 11:00:42

Hi hakjoon,

I’ve noticed a very small issue — posts cannot be saved :))

Here is the output when I press the “Save” button:

Fatal error:
Error: '' is not an integer
assert_int()
textpattern/include/txp_article.php:76 array_map()
textpattern/include/txp_article.php:54 article_post()
textpattern/index.php:141 include()
in /mnt/old/var/httpuser/#/www/textpattern/lib/txplib_misc.php on line 2225

hakjoon · 2009-12-01 13:04:01

iblastoff reported something similar but I just can’t replicate it.

Does it happen if the plugin is enabled but tinyMce is off?
What browser?

oh, oh I think this might be it.

Do you have Hide “Use textile” Dropdowns: turned on? I think the way I’m handling this trhough pluggable_ui might be to blame

I’ll keep looking the more detail you can give me the better.

Last edited by hakjoon (2009-12-01 13:12:02)

beztak · 2009-12-01 13:29:51

I’ve run into the same problem as Webspy (I had to downgrade to older version). It happend in all browser and yes I had hide Use Textile.

hakjoon · 2009-12-02 00:34:11

0.9.6 should hopefully fix this.

webspy · 2009-12-02 07:36:20

It works! I really appreciate it, great work.

One more thing — I was wondering whether you could use a variable instead of the text “Toggle Editor” — in order to translate it. (And not to rewrite it with every release. :) Thank you!

Last edited by webspy (2009-12-02 10:31:25)

hakjoon · 2009-12-02 13:14:51

It actually does use a variable already. In this last rewrite I made it a little harder to do a Lang file but I always wanted people to translate it.

Would splitting it up into a separate Lang plugin be something people woul be interested in? I I could easily break the language stuff into a separate plugin. At very least I’ll move it out of the class so it can be added to.

webspy · 2009-12-02 14:22:24

Oh, my bad… I just glanced at the code and noticed that there are untranslated sentences and I did not realize it’s there only for case when no language is selected.
Sorry. You’re great, by the way, I loove your plugins :)

hakjoon · 2009-12-02 14:49:39

No problem. It’s not something that is advertised, or is there an obvious extension system right now. I’m going to see about building somthing out to allow extra Lang files as separate plugins.

Textpattern CMS

Textpattern CMS support forum

#649 2009-11-23 23:22:39

Re: hak_tinymce WYSIWYG article editor

#650 2009-11-24 08:34:25

Re: hak_tinymce WYSIWYG article editor

#651 2009-11-24 08:55:36

Re: hak_tinymce WYSIWYG article editor

#652 2009-11-24 14:52:03

Re: hak_tinymce WYSIWYG article editor

#653 2009-12-01 11:00:42

Re: hak_tinymce WYSIWYG article editor

#654 2009-12-01 13:04:01

Re: hak_tinymce WYSIWYG article editor

#655 2009-12-01 13:29:51

Re: hak_tinymce WYSIWYG article editor

#656 2009-12-02 00:34:11

Re: hak_tinymce WYSIWYG article editor

#657 2009-12-02 07:36:20

Re: hak_tinymce WYSIWYG article editor

#658 2009-12-02 13:14:51

Re: hak_tinymce WYSIWYG article editor

#659 2009-12-02 14:22:24

Re: hak_tinymce WYSIWYG article editor

#660 2009-12-02 14:49:39

Re: hak_tinymce WYSIWYG article editor

Board footer