Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2005-10-02 07:45:44

Skubidu
Archived Plugin Author
Registered: 2004-10-23
Posts: 611
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Hey Destry!

I’ve no problem with what you’re saying, so I changed the plugin name: It’s now called nhn_livecommentpreview. The tag names changed, too, so please check the plugin help.

I changed the first part of the plugin description, too, so it now says:

This plugin is heavily based on the live comment hack described by Jon Hicks using code by Stuart Langridge and Jeff Minard.

This was a note that was formerly output as a comment in the javascript.

The new download link is nhn_livecommentpreview-v0.2.txt.

Last edited by Skubidu (2005-10-02 09:49:24)

Offline

#14 2005-10-02 09:47:49

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,912
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Perfect. Thanks Skub!

Offline

#15 2005-10-02 22:56:57

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Thats great, thanks! I feel more comfortable with the name now.

I’ve been hoping that someone could create a plugin on this. Justin Low has also stopped development of low_discuss, which allowed you to bypass the standard comment preview. It makes my day to have a plugin that combines the live preview AND the preview hack in one! When I get a chance, I’ll be incorporating this into my site, and throwing away all my hacks for good – and that is a VERY good feeling!!

Last edited by jonhicks (2005-10-02 22:57:24)


Cheers,
Jon VC#9

Offline

#16 2005-10-03 08:30:17

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Well I’ve incorporated it, but the comment form is a no show. I went back and triple checked all the tags were right (I moved the javascript to an external file though), but I can’t get that form to show itself (its not in the source code).

Any ideas where I might have gone wrong appreciated!


Cheers,
Jon VC#9

Offline

#17 2005-10-03 14:40:11

zoeglingjulian
Member
From: London, UK
Registered: 2004-12-23
Posts: 52
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

The documentation’s got some spelling mistakes.

<txp:nhn_livecommentpreview> should be <txp:nhn_livecommentpreview /> and

<txp:nhn_comment_form /> should be <txp:nhn_comments_form />.

That worked for me, at least.

Offline

#18 2005-10-03 15:10:22

Skubidu
Archived Plugin Author
Registered: 2004-10-23
Posts: 611
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Oh! I’m really sorry about these typos!
So, this is a memo for me: don’t work that late ;o)

I hope I fixed all typos now, the download has been updated. It’s just an update of the help text, if you downloaded the previous version, you just have to follow the instructions above made by zoeglingjulian.

Offline

#19 2005-10-03 20:44:45

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Excellent! All working perfectly!

I still have to hack this to enable my own customizations, but at least I can do that to the plugin code, and not the main Textpattern files. This officially ends all my hacks to the system – hooray!


Cheers,
Jon VC#9

Offline

#20 2005-10-03 21:29:01

aba
Plugin Author
Registered: 2004-04-14
Posts: 119

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

> jonhicks wrote:

> I still have to hack this to enable my own customizations, but at least I can do that to the plugin code, and not the main Textpattern files.

Anything that might be interesting for others and may be included in future versions of the plugin?

Offline

#21 2005-10-04 11:38:42

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

> aba wrote:

> Anything that might be interesting for others and may be included in future versions of the plugin?

Its mainly just styling stuff (to work with my comments box style), adding class names and the like, and a tabindex="4" to the <textarea>, so that tabbing worked. The only addition that might be of interest is incorporating this: http://livsey.org/experiments/textareatools/, which just needs a classname added to the <textarea>

The other hacks were just to put some non-breaking spaces in around the checkboxes and submit, although when I get time I’ll do the css properly. It would be nice if the checkbox labels were enclosed in <label> tags, as that would give a hook (as well as being semantic/righteous/worthy).


Cheers,
Jon VC#9

Offline

#22 2005-10-04 16:51:19

thomasstache
Member
From: Dresden, Germany
Registered: 2005-01-18
Posts: 14
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

<blockquote>jonhicks wrote:
It would be nice if the checkbox labels were enclosed in <label> tags, as that would give a hook (as well as being semantic/righteous/worthy).</blockquote>

That would be revision 950. It’s already in the core!


Thomas Stache

Offline

#23 2005-10-04 18:39:04

Matt
Member
Registered: 2004-02-28
Posts: 92
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

I’m still not seeing the comment entry form.
Just to be sure, here are my forms and their tags:

comments_display:
<code>
<txp:comments />
<txp:if_comments_allowed>
<txp:nhn_comments_form />
</txp:if_comments_allowed>
</code>

comment_form:
<code>
<txp:nhn_livecommentpreview />
</code>

Should these both be “Comment” type forms, or should one be an “article” type?

Offline

#24 2005-10-04 18:48:30

zoeglingjulian
Member
From: London, UK
Registered: 2004-12-23
Posts: 52
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

I’ve got a request. I tried the plugin and find it great so far, but it doesn’t seem to do smart quotes or dashes. Neither do they work on my test install nor do they on Jon Hicks’ site, so I guess it’s not a bug but by design… is there a way to enable that functionality?

Offline

Board footer

Powered by FluxBB