Textpattern CMS support forum

You are not logged in. Register | Login | Help

#11 2005-10-02 07:11:51

Skubidu
Plugin Author
Registered: 2004-10-23
Posts: 611
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

I’m sorry, if you don’t like the name. As I started using Textpattern a year ago, I learned to know about this live preview as the “Hicks live preview” – that’s why it’s named like this.

What would you prefer? Just “nhn_livepreview” or “nhn_livecommentpreview”? For me it’s just a name to know what the plugin is all about – I can change it, if you like it.

Offline

#12 2005-10-02 07:26:32

Destry
Moderator
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,295
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Skubidu, it’s not about liking the name or not, and we certainly don’t think you meant anything but full respect, it’s just that Jon made it clear the live comment preview stuff was not of his origin, so it’s simply not appropriate to name it after him, or you could (indirectly) put Mr. Hicks in a bad position. Also, as a potential user of the plugin, I don’t want to be advertising a wrongly named product on my Web site.

Why not just name it nhn_livecommentpreview, and in your documentation make it clear where the code history comes from?


Wordworkin’ for you.

Offline

#13 2005-10-02 07:45:44

Skubidu
Plugin Author
Registered: 2004-10-23
Posts: 611
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Hey Destry!

I’ve no problem with what you’re saying, so I changed the plugin name: It’s now called nhn_livecommentpreview. The tag names changed, too, so please check the plugin help.

I changed the first part of the plugin description, too, so it now says:

This plugin is heavily based on the live comment hack described by Jon Hicks using code by Stuart Langridge and Jeff Minard.

This was a note that was formerly output as a comment in the javascript.

The new download link is nhn_livecommentpreview-v0.2.txt.

Last edited by Skubidu (2005-10-02 09:49:24)

Offline

#14 2005-10-02 09:47:49

Destry
Moderator
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,295
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Perfect. Thanks Skub!


Wordworkin’ for you.

Offline

#15 2005-10-02 22:56:57

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Thats great, thanks! I feel more comfortable with the name now.

I’ve been hoping that someone could create a plugin on this. Justin Low has also stopped development of low_discuss, which allowed you to bypass the standard comment preview. It makes my day to have a plugin that combines the live preview AND the preview hack in one! When I get a chance, I’ll be incorporating this into my site, and throwing away all my hacks for good – and that is a VERY good feeling!!

Last edited by jonhicks (2005-10-02 22:57:24)


Cheers,
Jon VC#9

Offline

#16 2005-10-03 08:30:17

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Well I’ve incorporated it, but the comment form is a no show. I went back and triple checked all the tags were right (I moved the javascript to an external file though), but I can’t get that form to show itself (its not in the source code).

Any ideas where I might have gone wrong appreciated!


Cheers,
Jon VC#9

Offline

#17 2005-10-03 14:40:11

zoeglingjulian
Member
From: London, UK
Registered: 2004-12-23
Posts: 52
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

The documentation’s got some spelling mistakes.

<txp:nhn_livecommentpreview> should be <txp:nhn_livecommentpreview /> and

<txp:nhn_comment_form /> should be <txp:nhn_comments_form />.

That worked for me, at least.

Offline

#18 2005-10-03 15:10:22

Skubidu
Plugin Author
Registered: 2004-10-23
Posts: 611
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Oh! I’m really sorry about these typos!
So, this is a memo for me: don’t work that late ;o)

I hope I fixed all typos now, the download has been updated. It’s just an update of the help text, if you downloaded the previous version, you just have to follow the instructions above made by zoeglingjulian.

Offline

#19 2005-10-03 20:44:45

jonhicks
Member
From: Oxfordshire UK
Registered: 2004-03-22
Posts: 256
Website

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

Excellent! All working perfectly!

I still have to hack this to enable my own customizations, but at least I can do that to the plugin code, and not the main Textpattern files. This officially ends all my hacks to the system – hooray!


Cheers,
Jon VC#9

Offline

#20 2005-10-03 21:29:01

aba
Plugin Author
Registered: 2004-04-14
Posts: 119

Re: [plugin] [ORPHAN] nhn_livecommentpreview: JavaScript live comment preview

> jonhicks wrote:

> I still have to hack this to enable my own customizations, but at least I can do that to the plugin code, and not the main Textpattern files.

Anything that might be interesting for others and may be included in future versions of the plugin?

Offline

Board footer

Powered by FluxBB