Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: hak_article_image
hakjoon wrote:
Not yet. I haven’t had a lot of time to work on TXP lately, but I might be able to get an update with some of these issues that don’t require a new image routine out this week. Let me see what I can do.
Ok mate, thanks for the fast reply :¬)
Offline
#62 2006-07-24 23:58:03
- reptilerobots
- Member
- Registered: 2005-08-20
- Posts: 72
Re: hak_article_image
yes, thanks for the reply, I hacked the code and replaced <code> return join(’ ‘,$out); </code> with <code> return trim(join(’ ‘,$out)); </code> and still get the spaces. Image float works, but that is causing other problems.
Offline
Re: hak_article_image
Ok I have a hack that will work and this is fixed in SVN so it shouldn’t cause any problems when 4.0.4 comes out.
In /textpattern/publish/taghandlers.php look for the thumbnail function around line 92.
The main thing is change line 127 from
return join(' ',$out); to return join('',$out); no space between the quotes. This will remove the space after the img tag. In order to not break anything add space before align= and style= on lines 122 and 123.
This change is in SVN so it will be there when you upgrade to the next version whenever it comes out. You don’t need the trim().
Shoving is the answer – pusher robot
Offline
#64 2006-07-26 21:15:21
- reptilerobots
- Member
- Registered: 2005-08-20
- Posts: 72
Re: hak_article_image
awesome, it is all coming together. Is there a way to modify the poplinks? My pop up windows should be about 40 pixels wider and taller so that there aren’t any scrollbars.
Offline
Re: hak_article_image
Working on it. Currently no since it uses the built in function.
Last edited by hakjoon (2006-07-26 22:31:51)
Shoving is the answer – pusher robot
Offline
#66 2006-07-26 22:35:47
- reptilerobots
- Member
- Registered: 2005-08-20
- Posts: 72
Re: hak_article_image
Ok, cool….. so I’d have to hack the txp code to accomplish this?? Youd think it would work correctly…….
Offline
Re: hak_article_image
reptilerobots wrote:
Ok, cool….. so I’d have to hack the txp code to accomplish this?? Youd think it would work correctly…….
It kind of depends on which browser you are using. Some do the scrolls and some don’t. It kind of depends on the amount of default body padding each browser applies.
I’m putting the final tweaks on an update that will allow you increase the width and height of the popups by a user defined number.
And it has a bunch of other goodies too.
Shoving is the answer – pusher robot
Offline
#68 2006-07-27 02:31:44
- reptilerobots
- Member
- Registered: 2005-08-20
- Posts: 72
Re: hak_article_image
awesome sounds great, im sure by the time you have that updated, Ill be ready to get my website up and live. When do you expect to get finished?
Offline
Re: hak_article_image
New version 0.4. An almost full rewrite with lots of new options, and hopefully no new bugs.
Some of the changes:- Limit now works differently, by default shows all images
- Option to link to a section
- Option to link to the image directly
- Option to pass an anchor
- Option to open all link types in a popup
- Option to set rel attribute
- Options to pad the popup window
- Option hide image passed in the url
- Option to have no link at all around image (useful for wrapping with permlink)
Shoving is the answer – pusher robot
Offline
Re: hak_article_image
Excellent news – this is my favourite extention. Thanks!
Edit: The link is to an empty file. Well, code-wise – it still has the rem’ed header… please fix :¬)
Last edited by rossharvey (2006-08-23 15:06:06)
Offline
Re: hak_article_image
Ross,
It seems to work fine for me. I tried it in Firefox(mac/win), Safari and IE. Although the line breaks are pretty funky in Notepad for some reason, but it still works.
Try just doing a select all and copy. I’ve had cases before where depending on how browsers handle TXT files the plugin code is not visible but it’s still there. This is the first release I’ve done using Inspired’s plugin builder instead of Zem’s template, maybe something is different between them.
Shoving is the answer – pusher robot
Offline
Re: hak_article_image
Ah yes my apologies, for some reason it wasn’t being rendered in Notepad or Notepad++. Fine on my home PC.
Thanks very much :¬)
Offline