Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2016-05-02 11:41:49

etc
Developer
Registered: 2010-11-11
Posts: 5,053
Website GitHub

Re: multiple select preference saving?

Technicalities apart, we have to decide whether an empty '' item can be part of an options list: 'apple,,banana'? I would say no, otherwise what is '' itself: an empty list or a list with one empty element? In many places txp already uses do_list_unique() function that removes empty elements by default, so I would adhere to this behaviour.

Offline

#26 2016-05-02 11:49:50

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: multiple select preference saving?

etc wrote #298915:

Technicalities apart, we have to decide whether an empty '' item can be part of an options list: 'apple,,banana'? I would say no…

I agree, I can’t really imagine how an empty value would be useful but others may have an other opinion…?


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#27 2016-05-02 21:03:30

etc
Developer
Registered: 2010-11-11
Posts: 5,053
Website GitHub

Re: multiple select preference saving?

I have added checkbox sets to the collection.

Offline

#28 2016-05-03 13:54:27

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: multiple select preference saving?

etc wrote #298920:

I have added checkbox sets to the collection.

That could be useful; we now have a great prefs package.
Thanks for your work and your pedagogy!


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#29 2016-05-03 15:07:22

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,271
Website GitHub

Re: multiple select preference saving?

NicolasGraph wrote #298936:

That could be useful; we now have a great prefs package.

It’s getting better, I agree. Don’t rely on this new function too much right now though, as we’ll probably refactor the parameters later today.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#30 2016-05-03 15:23:31

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: multiple select preference saving?

Bloke wrote #298943:

It’s getting better, I agree. Don’t rely on this new function too much right now though, as we’ll probably refactor the parameters later today.

Yes, I saw your note on Github ; no worry. I’m trying to get that working for now.

Last edited by NicolasGraph (2016-05-03 18:32:05)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#31 2016-05-03 21:56:22

etc
Developer
Registered: 2010-11-11
Posts: 5,053
Website GitHub

Re: multiple select preference saving?

Bloke wrote #298943:

Don’t rely on this new function too much right now though, as we’ll probably refactor the parameters later today.

We can even postpone core handlers to cf era, integrating into 4.6 only array-to-list prefs saves to let plugins use their owns.

Offline

Board footer

Powered by FluxBB