Textpattern Support Forum

Wet

My apologies – due to a crazy schedule, I never followed up on your attempted fix for my post here.

It was the same problem DST issue reported by MattD and JohnStephens, and r33271 seems to fix the one install I had time to update and check.

Thanks

Mike

Could this be a bug?
<txp:if_article_id> on article list context is not being evaluated

Thanks.

maniqui wrote:

Could this be a bug?
<txp:if_article_id> on article list context is not being evaluated

I definitely consider it a bug. :) However, it was all the same in previous versions, 4.0.8 at least, and the code of this tag suggests this behaviour is on purpose.

Anyway, I would really like to see this element to evaluate to false instead of being dropped in article list context. It would be more intuitive and more convenient for typical use, imho. There is no reason this tag’s functionality should overlap with that of if_individual_article.

I’m going to replace lines 1477-1480 of publish/taghandler.php as follows:

return parse(EvalElse($thing, $id and in_list($thisarticle['thisid'], $id)));

Last edited by hoho (2009-09-04 19:16:20)

Patch submitted. I just had to think more thoroughly about it to base my argumentation on more solid basics than ‘intuition’. :) Here’s the core.

As far as I can tell, the if_article_id tag is the only TXP tag that
differentiates between a single article context and an article list context
in the sense that the tag does something in one context and does absolutely
nothing in the other.

Moreover, the tag is unique :) among other conditional TXP tags: it is the
only conditional tag that can evaluate neither clause without reporting an
error. Indeed, I haven’t seen such an if-statement in any other programming
language. :)

Having said all this, I would recommend changing semantics of the
if_article_id tag so that the condition evaluates to false if no value of
the ‘id’ can be determined. That’s exactly what the patch does.

The other option – reporting an error – would introduce a new type of error
in TXP which is not desirable in terms of simplicity of the overall
semantics, is it?

P.S. The change is not backward-compatible but if you think it through,
casulties should be rather limited – it should affect only the unlikely
(imho) cases when one uses an else-clause while relying on the fact that
the tag is ignored in an article list context.

Last edited by hoho (2009-09-06 21:29:01)

Hi, I’ve just upgraded to the new textpattern version.

However, I’ve noticed that there is absolutely no colour in the background, unlike version 4.0.8. Why is that?

Thanks!