Textpattern Forum

You are not logged in. Register | Login | Help

#141 2009-08-25 12:13:11

Leonick
Member
Registered: 2007-07-30
Posts: 15

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Because i’m tracking all scripts errors, with error_reporting(E_ALL) I have this error :

[8] ob_end_clean() [<a href=‘ref.outcontrol’>ref.outcontrol</a>]: failed to delete buffer. No buffer to delete. on line 1768 on file /…/textpattern/lib/txplib_misc.php

to resolve this, on handle_lastmod function i’ve modified while (ob_end_clean()); with while (ob_get_length()>0) ob_end_clean();

Offline

#142 2009-08-25 14:47:57

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 759
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Wet

My apologies – due to a crazy schedule, I never followed up on your attempted fix for my post here.

It was the same problem DST issue reported by MattD and JohnStephens, and r33271 seems to fix the one install I had time to update and check.

Thanks

Mike

Offline

#143 2009-08-25 23:02:24

dl33
Member
Registered: 2006-06-17
Posts: 192
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Works very well up to now. The only question I have is whether it makes sense to share user accounts between the different sites when using the multiple sites feature? Is it possible to create a link between the two user tables?

Offline

#144 2009-08-25 23:04:52

maniqui
Moderator
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 2,989
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#145 2009-08-26 00:18:53

maniqui
Moderator
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 2,989
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Well, let me add to the confussion:
txp:if_article_list> inside <txp:article_custom /> always return true

Last edited by maniqui (2009-08-26 00:19:29)


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#146 2009-09-04 16:22:05

hoho
Plugin Author
Registered: 2009-04-05
Posts: 11

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

maniqui wrote:

Could this be a bug?
txp:if_article_id> on article list context is not being evaluated

I definitely consider it a bug. :) However, it was all the same in previous versions, 4.0.8 at least, and the code of this tag suggests this behaviour is on purpose.

Anyway, I would really like to see this element to evaluate to false instead of being dropped in article list context. It would be more intuitive and more convenient for typical use, imho. There is no reason this tag’s functionality should overlap with that of if_individual_article.

I’m going to replace lines 1477-1480 of publish/taghandler.php as follows:

return parse(EvalElse($thing, $id and in_list($thisarticle['thisid'], $id)));

Last edited by hoho (2009-09-04 19:16:20)

Offline

#147 2009-09-04 16:29:51

ruud
Developer emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 4,542
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

^^ submit a patch to the devs!

Offline

#148 2009-09-05 15:40:23

hoho
Plugin Author
Registered: 2009-04-05
Posts: 11

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Patch submitted. I just had to think more thoroughly about it to base my argumentation on more solid basics than ‘intuition’. :) Here’s the core.

As far as I can tell, the if_article_id tag is the only TXP tag that
differentiates between a single article context and an article list context
in the sense that the tag does something in one context and does absolutely
nothing in the other.

Moreover, the tag is unique :) among other conditional TXP tags: it is the
only conditional tag that can evaluate neither clause without reporting an
error. Indeed, I haven’t seen such an if-statement in any other programming
language. :)

Having said all this, I would recommend changing semantics of the
if_article_id tag so that the condition evaluates to false if no value of
the ‘id’ can be determined. That’s exactly what the patch does.

The other option – reporting an error – would introduce a new type of error
in TXP which is not desirable in terms of simplicity of the overall
semantics, is it?

P.S. The change is not backward-compatible but if you think it through,
casulties should be rather limited – it should affect only the unlikely
(imho) cases when one uses an else-clause while relying on the fact that
the tag is ignored in an article list context.

Last edited by hoho (2009-09-06 21:29:01)

Offline

#149 2009-09-06 16:00:08

Walker
Plugin Author
From: Boston, MA
Registered: 2004-02-24
Posts: 592
Website

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Setting up multi-site manager on Media Temple’s Grid Server.

Last edited by Walker (2009-09-06 17:02:12)

Offline

#150 2009-09-19 22:26:42

sarah
Member
Registered: 2009-08-13
Posts: 46

Re: Feedback to: Textpattern CMS 4.2.0 Release Candidate: Help us test!

Hi, I’ve just upgraded to the new textpattern version.

However, I’ve noticed that there is absolutely no colour in the background, unlike version 4.0.8. Why is that?

Thanks!

Offline

Board footer

Powered by FluxBB