Textpattern Forum

You are not logged in. Register | Login | Help

#51 2009-01-24 22:42:01

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 700

Re: smd_calendar: complete schedule / event / calendar / diary

Stef – Yes, I was testing the 4.0.8 release when I noticed this – if its any help this behavior looks quite different on localhost. I’ve seen some odd urls that look like this:

http://localhost/?s=events&m=2&y=2009&calid=event_cal&s=events, so I’m guessing url rewriting is probably indicated as suspect. ver 0.33, ver 0.4 behaves consistently on both my server and localhost.

Last edited by rsilletti (2009-01-25 01:25:48)

Offline

#52 2009-01-25 01:01:25

stopsatgreen
Member
Registered: 2008-07-03
Posts: 50

Re: smd_calendar: complete schedule / event / calendar / diary

I’m using TXP 4.08, and when I try to install this plugin I get the error: Badly formed or empty plugin code.

Offline

#53 2009-01-25 01:11:00

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 5,982
Website

Re: smd_calendar: complete schedule / event / calendar / diary

stopsatgreen wrote:

I’m using TXP 4.08, and when I try to install this plugin I get the error: Badly formed or empty plugin code.

Try the compressed version,

woof

D’oh, yes I forgot that my beautifully crafted prose gets turned into HTML which is somewhat bigger than Textile. I’ll refactor the docs: just the facts :-)

rsilletti

Thanks for the extra info. Bug hunting in progress…

Last edited by Bloke (2009-01-25 01:11:28)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern.

Txp Builders – finely-crafted code, design and Txp

Offline

#54 2009-01-25 01:28:06

stopsatgreen
Member
Registered: 2008-07-03
Posts: 50

Re: smd_calendar: complete schedule / event / calendar / diary

Try the compressed version,

Worked, thanks.

Offline

#55 2009-01-27 01:33:54

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 700

Re: smd_calendar: complete schedule / event / calendar / diary

Event Calendar , event posted by internal settings to my current time zone is showing in the next day? It was displayed properly for an extended length of time and then shifted a day. I’m tempted to blame my own code, but I’ve noticed some other odd stuff as well (posting times changing without my input), I’m wondering how this plugin handles time offsets.

Posted by: Rick · 05 Feb 2009 · 20:30:00 (actual posting time of “Open Mic 2” event )

Preferences setting for time zone is GMT – 8.00

Last edited by rsilletti (2009-01-27 02:54:50)

Offline

#56 2009-01-27 09:37:45

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 5,982
Website

Re: smd_calendar: complete schedule / event / calendar / diary

Rick

For general info, see rant #1 and #2, the plugin help and if you feel brave, look at the great time debate

posting times changing without my input

Hmmm, not supposed to! From memory, the plugin reads the true database timestamps and applies the server offset. It uses built-in TXP and PHP functions to work out the dates.

I think — but don’t quote me on this — when you (re)save articles, the time is adjusted based on DST/time zone in effect at the time of Save. I can’t remember if that’s the case; it might leave it alone. Whatever, one thing that does happen is that when you alter the time zone/DST in Admin->Prefs, the database timestamps remain the same but all calculated offsets are shifted by TXP on the admin side.

Thus, any change in time zone/DST after an article is posted makes it appear on the admin side like the time’s wrong. If you notice this and “correct” it, your events will drift on the calendar because it uses the database timestamps instead.

Bottom line: time handling in TXP is a mess. And if you think it’s bad using the plugin, try writing and testing one with all this time stuff moving round you! I nearly melted :-P

But if you find that the plugin is actually altering dates when nothing has changed on the admin side or the server, I’d love to see a test case so I can track it down and squash the bug. Similarly, if you have any notions or ideas on how to handle all this, I’d love to hear them/see some code fragments. I’m fresh out of ideas.

FYI, mrdale’s on GMT-08 so you might want to pick his brain on how he handles it.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern.

Txp Builders – finely-crafted code, design and Txp

Offline

#57 2009-01-27 10:00:50

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 700

Re: smd_calendar: complete schedule / event / calendar / diary

Yes, I’d forgotten about the shift from the database stamps – and that explains a lot. Think I’ll just keep it simple until my headache goes away. Haven’t been able to pin down anything specific with this and all else seems to work very nicely. Thanks for this, I’m having a great time with the possibilities.

Last edited by rsilletti (2009-01-27 10:09:03)

Offline

#58 2009-01-27 20:38:37

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 700

Re: smd_calendar: complete schedule / event / calendar / diary

if you think it’s bad using the plugin, try writing and testing one with all this time stuff moving round

ras_if_dates, I can feel your pain.

I’m still trying to use the gmt attribute to move the calender itself into local time, it doesn’t seem to have any effect whether it be left at default or explicitly set to “0”. Am I correct in assuming that it should do so?

Offline

#59 2009-01-28 19:53:49

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 5,982
Website

Re: smd_calendar: complete schedule / event / calendar / diary

rsilletti wrote:

I’m still trying to use the gmt attribute to move the calender itself into local time

*ahem* Right. About that.

A long time ago in a conversation far far away I discussed having issues with date generation. Throughout the entire Beta phase of the plugin I was using safe_strftime() — as mdp_calendar did before me — to generate the dates, which takes the gmt and lang attributes. Trouble was, I found as soon as the timezone in prefs was varied from GMT, using safe_strftime() to generate calendar events — having already been applied at article creation time — caused:

  1. a double offset if you were ahead of GMT
  2. a cancellation of some of the built-in offset if you were behind GMT

(or the other way round, I forget which)

The “fix” (if you can call it that) was to use PHPs native strftime() instead. So I swapped out almost all the calls and thus gmt became practically unused. I say “practically” because it is still used to generate the days of the week, though my guess is you’d probably not see any major problems if I took it out of there too.

I was hoping that by introducing gmt and lang you could do (probably) what you are trying to do now: “set” dates to a reference point and then all this timezone crap would go away. Sadly, TXP’s method of applying timezone on article display scuppered my plans for date domination. This could be for a number of reasons:

  1. TXP’s date mechanism is warped
  2. The world’s date system is convoluted
  3. I just plain don’t understand it all
  4. Some/all of the above

The bottom line is that the gmt and lang attributes remain, even though they’re not exactly used in any great capacity any more. I’ve been contemplating taking them out entirely but I wanted to keep them lurking in case I found that I should really be using safe_strftime(). I ran out of space in the plugin help to talk about it and kept meaning to mention it here before anyone noticed. Guess that backfired too, sorry :-(

If anyone has the definitive answer about how I can treat dates neutrally so they always appear at the date you set, I would like love to know.

May I ask how you approached the whole date conundrum with ras_if_dates? Perhaps I should be doing the same so that gmt actually becomes a useful attribute again? This can drive a man insane.

Last edited by Bloke (2009-01-28 19:54:41)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern.

Txp Builders – finely-crafted code, design and Txp

Offline

#60 2009-01-29 01:53:45

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 700

Re: smd_calendar: complete schedule / event / calendar / diary

tz_offset() returns a value calculated this way:

Server_Offset = GMT – Current server time.
CMS offset = time zone setting – Server_Offset + DST

if I put a tag that goes like this in a page template <txp:tz_offset /> it
returns 0 which I assume means that my server is on Greenwich Mean Time.

When TXP writes to the database, the timestamp is set using “NOW” as defined by mysql : expressed in the current time zone, so logically the timestamp is serverset.

I went around safe_strftime() and used $thisarticle[‘posted’] + tz_offset() directly as a time base for comparisons; much simpler than full scale date handling in its context. I’m not sure why safe_strftime isn’t working for you as advertised, but the worst tendency that I had with this was inverting a value in the process without realizing it – nothing like that to make even the best work look wrong. Unless I have a fly on the back of my head that no one is telling about, this works in displayed time and moves with the settings.

function ras_dates_today($atts,$thing)
	{
  		global $thisarticle;
		assert_article();
		extract(lAtts(array(
			'type' => 'apos',
			'setdate' => '',
			'offset' => ''
		),$atts));

	switch($type) {
		case 'apos' : $tz_date = strtotime(date('Y-m-d', $thisarticle['posted'] + tz_offset()));
		break;
		case 'axpr' : $tz_date = strtotime(date('Y-m-d', $thisarticle['expires'] + tz_offset()));
		break;
		case 'amdf' : $tz_date = strtotime(date('Y-m-d', $thisarticle['modified'] + tz_offset()));
		break;
	}

	$thedate = ($setdate) ? $setdate : date('Y-m-d' , mktime() + tz_offset() - ($offset * 86400));
		 return parse(Evalelse($thing, strtotime($thedate) == $tz_date ));
	}

Offline

Board footer

Powered by FluxBB