Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#49 2008-01-02 14:13:06

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

the-exit: nope sorry. i have a bunch of older revisions but none are labelled. this is where my own laziness kicks me in the ass. although i don’t know why it wouldn’t completely show up for you though. make sure its actually enabled? try 0.6c if you want. tested in safari 3+ beta (XP), opera 9.24+, FF 2.0.11, IE6 and IE7.

maverick:i have no idea what those other plugins do. i’m just working with the original stm_image_uploader code. either way 0.6c is out. it should get rid of the odd ‘login via iframe’ nonsense. also the jquery solution i thought would fix some things ended up not even working in any browser except Firefox…go figure. if anyone knows of a reliable automatic-resizing iframe solution using jquery let me know.

i’ve installed 0.6c on my local test server, on my own site, and on two separate sites without any issues so far. of course this means nothing for the rest of you :)

Last edited by iblastoff (2008-01-02 15:43:18)

Offline

#50 2008-01-02 15:12:15

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 976
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

@ the-exit – If 0.6c doesn’t work for you and you still want 0.5b, email me at themaverick at michiganub dot com

@ibastoff – Thanks Steve. Will try out 0.6c when I get a chance.

Mike

Offline

#51 2008-01-02 16:02:55

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 976
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

0.6c seems to have fixed the iFrame issue I was having.

Thanks

Mike

Last edited by maverick (2008-01-02 16:03:04)

Offline

#52 2008-01-02 16:59:46

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 976
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

I did find another issue, at least in Safari 3.x (Mac). I uploaded an image. I wanted to use the thumbnail, but the dimensions were wrong for the thumbnail. So instead of inserting the image I tried to go to the image tab to resize it. Safari popped up a dialogue window (actually two identical windows) informing me that I had made changes to the page and they would be lost – click okay to continue, click cancel to stay on the page. Clicking okay on both closed the pop up windows, but did not allow me to continue off the page. I had to close the tab. The navigation links for the page were in essence no longer available.

However, the image was uploaded, and I was able to open a new tab, edit it, and then insert it.

fwiw

Mike

Offline

#53 2008-01-02 17:14:24

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

hmm? the plugin doesn’t control any actual thumbnail resizing at all except on the ‘thumbnail preview’. actual thumbnail creation relies on whatever size is set in your image tab. if the upload form is set to display in the sidebar, all it does is display your thumbnail preview at a fixed width of 150px (ie. <img src="yourthumbnail.jpg" width="150" /> so people with relatively large thumbnails won’t get a messed up write tab area). so basically if you have your thumbnail size set to 200px in the image tab, whenever you upload via the plugin the ‘preview’ will just display it at 150px instead (to preserve the write tab layout). this is ugly but i’m not sure of a better way to do this yet.

unfortunately that also means the thumbnail preview will look like crap since its using browser resizing (at least for IE/FF users since safari has better browser-resized image rendering)

although if people want, i can add a preference like “show thumbnail at actual size?” or something like that.

not much of an improvement but i should probably just be adding a max-width style of 150 instead of hardcoded width for the thumbnail preview.

Last edited by iblastoff (2008-01-02 17:22:42)

Offline

#54 2008-01-02 17:33:41

maverick
Member
From: Southeastern Michigan, USA
Registered: 2005-01-14
Posts: 976
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

I’m sorry. I didn’t mean to imply that the issue was with thumbnail resizing. :D Rather, after uploading the image, I thought to myself “I better change the default thumbnail for the that image”. So I tried to leave the write tab and go to the image tab, so I could resize it from the image tab.

The problem I ran into, is that Safari recognized I had added/changed content on the page when I uploaded the image, but I had not “saved” it (that is, saved that page). So it pops up a warning when I click on a link that would leave the page, or when I try to close the window. Under normal conditions you can click “ok” and the new page loads. In this case, two warnings are popping up (probably one for the page in the iFrame and one for the main page). Clicking ok doesn’t allow you to leave the page. I suspect it may be due to having two instances of the warning.

I’m not sure there is anything that can be done unless the iFrame issue is worked around; I posted as a “known issue” item in case anyone else found themselves with the same problem.

Last edited by maverick (2008-01-02 17:34:07)

Offline

#55 2008-01-02 18:08:41

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

ahh sorry for misunderstanding. although i think thats just how safari for mac is? i don’t get any warning(s) at all using safari for XP, FF, IE, or opera after uploading an image and then attempting to navigate to another tab. i don’t think thats something i can control.

i think this plugin is going to become moot once asv_multicontent is developed further.

Offline

#56 2008-01-02 18:10:54

variaas
Plugin Author
From: Chicago
Registered: 2005-01-16
Posts: 402
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

Steve – I want to potentially merge the code base of asv_multicontent with yours. I’m shooting you another email to talk about how best to design. So far I’ve implemented uploading an image as well as importing an image based off a url.

Offline

#57 2008-01-02 22:44:00

Cliff Garber
New Member
From: Lynn, Mass.
Registered: 2006-10-08
Posts: 8
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

Steve, Mike, Matthias:

V0.6c is working in OmniWeb now, and I assume it works in Safari too. It’s not perfect, but it’s functional. Thank you all for pursuing this.

Cliff

Offline

#58 2008-01-03 00:42:30

the_ghost
Plugin Author
From: Minsk, The Republic of Belarus
Registered: 2007-07-26
Posts: 907
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

It would be nice to add ability to insert at cursor position <txp:image id="777" />. I mean not to use copy-paste hand method but some button :)

And another good feature – delete just uploaded image :)


Providing help in hacking ATM! Come to courses and don’t forget to bring us notebook and hammer! What for notebook? What a kind of hacker you are without notebok?

Offline

#59 2008-01-03 00:45:15

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

Cliff Garber wrote:

Steve, Mike, Matthias:

V0.6c is working in OmniWeb now, and I assume it works in Safari too. It’s not perfect, but it’s functional. Thank you all for pursuing this.

Cliff

glad its working for you cliff. i do agree this solution is far from perfect though.

Last edited by iblastoff (2008-01-03 00:45:25)

Offline

#60 2008-01-03 00:49:25

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: lam_image_uploader v0.6c (improved upload images from the write tab)

the_ghost wrote:

It would be nice to add ability to insert at cursor position <txp:image id="777" />. I mean not to use copy-paste hand method but some button :)

And another good feature – delete just uploaded image :)

i think the first part should be pretty easy to add. although then we get into all the different options of whether people want to use normal html, or textile, or txp tags. for starters i guess i’ll add the insert using <txp:image id="777" />.

as for deleting the uploaded image…i’m not sure if thats really necessary. i don’t really want to bring ALL the functionality of the image tab over to the write tab :P i’ll see what i can do though.

Last edited by iblastoff (2008-01-03 00:52:22)

Offline

Board footer

Powered by FluxBB