v. up to 4.0.2 - Author-Specific listings don't support pagination pro

Sandwich · 2005-11-03 14:59:01

If I am looking at a page that displays articles from a specific author (<code>index.php?author=John+Doe</code>), and have a <code><txp:older>< Previous</txp:older></code> link on the page, the link generated is <code>index.php?pg=2</code>, where it should be <code>index.php?author=John+Doe&pg=2</code>. In other words, the second page will not still be limited to that specific author.

The-Exit · 2005-11-16 19:45:02

I do have the same bug.

Any comments on this issue?

Jeremie · 2005-11-16 20:41:10

Just in case, you should publish your diagnostic infos.

The-Exit · 2005-11-16 20:48:00

diagnostics:
Version Textpattern: 4.0.2 (r1076)
last_update: 2005-11-03 22:56:36/2005-11-03 22:48:19
Absoluter Pfad der Seite: /home/httpd/vhosts/hauptstadtblog.de/httpdocs
$path_to_site: /home/httpd/vhosts/hauptstadtblog.de/httpdocs
Pfad Textpattern: /home/httpd/vhosts/hauptstadtblog.de/httpdocs/textpattern
Schema der URLs: section_id_title
open_basedir: /home/httpd/vhosts/hauptstadtblog.de/httpdocs:/tmp
Temporäres Verzeichnis: /home/httpd/vhosts/hauptstadtblog.de/httpdocs/textpattern/tmp
Seiten-URL: www.hauptstadtblog.de
PHP-Version: 4.4.0
server_time: 2005-11-16 21:44:54
MySQL: 4.1.15-Max
Regionale Einstellungen: de_DE.UTF-8
Server: Apache/2.0.49 (Linux/SuSE)
Apache-Version: Apache/2.0.49 (Linux/SuSE)

Inhalt der .htaccess-Datei:
————————————
#DirectoryIndex index.php index.html
#Options +FollowSymLinks
#RewriteBase /relative/web/path/

<IfModule mod_rewrite.c> RewriteEngine On RewriteCond %{REQUEST_FILENAME} -f [OR] RewriteCond %{REQUEST_FILENAME} -d RewriteRule ^(.+) – [PT,L]

RewriteRule ^(.*) index.php </IfModule>

#php_value register_globals 0

————————————

the pagination was built with the txp:author and txp:older tags.

Sandwich · 2005-11-17 10:04:59

<pre><code>
Textpattern version: 4.0.2 (r1076)
last_update: 2005-11-03 14:51:11/2005-11-03 13:07:57
Document root: /web/clients/kokaj/htdocs
$path_to_site: /web/clients/kokaj/htdocs
Textpattern path: /web/clients/kokaj/htdocs/textpattern
Permanent link mode: messy
Temp folder: /web/clients/kokaj/htdocs/textpattern/tmp
Site URL: www.kkcj.org
PHP version: 4.2.1
Register globals: 1
server_time: 2005-11-17 03:02:34
MySQL: 3.23.46
Locale: en_GB
Server: Apache/2.0.39 (Unix) PHP/4.2.1

Pre-flight check:
————————————
Your version of PHP has security related risks. Please turn register_globals off or update to a newer PHP version.
————————————

.htaccess file contents:
————————————
#DirectoryIndex index.php index.html
#Options +FollowSymLinks
#RewriteBase /relative/web/path/

<IfModule mod_rewrite.c> RewriteEngine On RewriteCond %{REQUEST_FILENAME} -f [OR] RewriteCond %{REQUEST_FILENAME} -d RewriteRule ^(.+) – [PT,L]

RewriteRule ^(.*) index.php </IfModule> ———————————— </code></pre>

The-Exit · 2006-06-21 08:11:58

This issue is still pending in 4.0.3

Is there any possibility of solving this bug for the next release?

Mary · 2006-06-21 08:36:16

Sure. This bug is on the list of things to check and correct, but I’ll take a peek right now. :)

Mary · 2006-06-21 08:59:58

How’s about that? I fixed that bug (r1357), and found another one to add to the list. :)

Edit: I’ve moved this thread to the dead letter office, so other devs know it’s been handled (unless anyone tells me otherwise). :)

Last edited by Mary (2006-06-21 09:01:14)

The-Exit · 2006-06-21 20:47:03

Hi Mary

I just updated the older function in my 4.0.3 rev 1188 version of Textpattern.

The article list is shown with the url: http://www.hauptstadtblog.de/autor/Matthias

Using your lines, the link for the second page is http://www.hauptstadtblog.de/autor/MatthiasSchlecker/?pg=2 which does not work.

Probably I do have to update the entire textpattern, or can this still be a bug?

Mary · 2006-06-22 00:56:44

First, the author name used for /author urls is not your login name, but your full name.

Edit: for example, my full name is defined as “Mary”, which is totally different than my login name. The links generate urls like “/author/mary”.

Second, there was another bug (its code is elsewhere in Textpattern) I found when I was working on this, where the /author urls primary behaviour (having nothing to do with the next/prev tags) is inconsistant: no author url will return a 404 when it should (like if an author does not exist). Rather, it will display the default contents of your default page instead. Unless you happen to use if_author, in which case then the default contents are not displayed, but you still don’t get a 404.

I am hoping to get this bug fixed right away.

Last edited by Mary (2006-06-22 00:58:12)

m00se · 2006-09-07 08:39:34

I fixed this in my 4.0.3 install by adding the following two lines in both functions for newer() and older() in textpattern/publish/taghandlers.php :

// following one line patches author pagination bug ~jt 9/6/6 $author_name = get_author_name($pretext[‘author’]); $url = pagelinkurl(array( ‘pg’ => $nextpg, ’s’ =>$pretext[’s’], ‘c’ => $pretext[‘c’], ‘q’ =>$pretext[‘q’], ‘a’ => @$pretext[‘a’], // following one line patches author pagination bug ~jt 9/6/6 ‘author’ => $author_name ));

cheers,
JT

The-Exit · 2006-09-08 12:54:11

Thank you for the code! This works great!

Textpattern CMS

Textpattern CMS support forum

#1 2005-11-03 14:59:01

v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#2 2005-11-16 19:45:02

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#3 2005-11-16 20:41:10

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#4 2005-11-16 20:48:00

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#5 2005-11-17 10:04:59

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#6 2006-06-21 08:11:58

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#7 2006-06-21 08:36:16

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#8 2006-06-21 08:59:58

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#9 2006-06-21 20:47:03

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#10 2006-06-22 00:56:44

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#11 2006-09-07 08:39:34

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

#12 2006-09-08 12:54:11

Re: v. up to 4.0.2 - Author-Specific listings don't support pagination pro

Board footer