Textpattern CMS

#1 2016-12-09 11:19:12

Gallex

Member

Registered: 2006-10-08

Posts: 1,289

comments_form: lots of deprecated errors in txp 4.6.2

i know, they are deprecated on 4.6, but how i should replace them?

textpattern/publish.php:1086 parse_form()
textpattern/publish.php:1110 doArticle()
textpattern/publish.php:696 parseArticles()</code></pre><pre dir="auto">Tag error: <b>&lt;txp:comments_form isize=&quot;25&quot; msgcols=&quot;45&quot; msgrows=&quot;10&quot; /&gt;</b> -> <b> Textpattern Notice: <strong>isize</strong> attribute is deprecated. while parsing form <strong>comments_display</strong> on page <strong>default_est</strong></b></pre>
<pre class="backtrace" dir="ltr"><code>textpattern/publish/taghandlers.php:2115 trigger_error()
comments_form()
textpattern/vendors/Textpattern/Tag/Registry.php:83 call_user_func()
textpattern/lib/txplib_publish.php:514 Textpattern\Tag\Registry-&gt;process()
textpattern/lib/txplib_publish.php:463 processTags()
textpattern/publish/taghandlers.php:3795 parse()
if_comments_allowed()
textpattern/vendors/Textpattern/Tag/Registry.php:83 call_user_func()
textpattern/lib/txplib_publish.php:514 Textpattern\Tag\Registry-&gt;process()
textpattern/lib/txplib_publish.php:463 processTags()</code></pre><pre dir="auto">Tag error: <b>&lt;txp:comments_form isize=&quot;25&quot; msgcols=&quot;45&quot; msgrows=&quot;10&quot; /&gt;</b> -> <b> Textpattern Notice: <strong>msgrows</strong> attribute is deprecated. while parsing form <strong>comments_display</strong> on page <strong>default_est</strong></b></pre>
<pre class="backtrace" dir="ltr"><code>textpattern/publish/taghandlers.php:2115 trigger_error()
comments_form()
......

#2 2016-12-09 11:51:14

philwareham

Core designer

From: Haslemere, Surrey, UK

Registered: 2009-06-11

Posts: 3,564

Website GitHub Mastodon

Re: comments_form: lots of deprecated errors in txp 4.6.2

You should be able to glean the information from the default theme, here and here.

Basically, the individual form field tags allow for size attributes on them now, for example:

<txp:comment_email_input size="32" />
<txp:comment_message_input cols="64" rows="4" />

#3 2016-12-09 13:21:22

Gallex

Member

Registered: 2006-10-08

Posts: 1,289

Re: comments_form: lots of deprecated errors in txp 4.6.2

could the error reason be the PHP7 ?

#4 2016-12-09 16:20:37

philwareham

Core designer

From: Haslemere, Surrey, UK

Registered: 2009-06-11

Posts: 3,564

Website GitHub Mastodon

Re: comments_form: lots of deprecated errors in txp 4.6.2

Gallex wrote #303216:

could the error reason be the PHP7 ?

No, the isize and msgcols attributes on txp:comments_form have simply been deprecated and you are being notified about it. Doesn’t affect your live site but you should amend the tags because the old attribute code will eventually be removed from core.