Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2016-04-03 23:06:46

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,079
Website

Write panel, reset time to now bug ?

Here is something that is puzzling me.

STR:

  1. Load any old article in the Write panel
  2. Click the ‘Reset time to now’ checkbox in the Date and time sub panel
  3. Save
  4. Observe that the date & time stamp did not change (in the Date and time sub panel)
  5. Note also that in the Comments sub panel the entry still says “expired”

Now go to the Article panel, note that the article now shows the expected time (“now”, basically ). Reloading the article in the Write panel of course displays the expected time stamp – and the comments field now shows the option to enable/disable comments for said article.

Following these steps with Textpattern 4.5.7, the time stamp is immediately displayed correctly upon saving.

TXP 4.6dev all updated, localhost on OS X. Comments are allowed but disabled after six weeks.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#2 2016-04-05 09:50:07

etc
Developer
Registered: 2010-11-11
Posts: 5,053
Website GitHub

Re: Write panel, reset time to now bug ?

It looks like the ajax response is still targeting #write-timestamp in the Write panel, but it’s gone/replaced with something else now.

Offline

#3 2016-04-05 11:57:31

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Write panel, reset time to now bug ?

I’m investigating fixes for this.

Offline

#4 2016-04-05 12:13:09

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,079
Website

Re: Write panel, reset time to now bug ?

etc wrote #298499:

It looks like the ajax response is still targeting #write-timestamp in the Write panel, but it’s gone/replaced with something else now.

Oh… that simple… (well sort of :-) – the ajaxy stuff is often way over my head). Yeah all those IDs have been changed a few months ago.

philwareham wrote #298502:

I’m investigating fixes for this.

Thanks for picking it up!


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#5 2016-04-11 16:50:04

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Write panel, reset time to now bug ?

This should be fixed in latest GitHub master – please test and let me know.

Offline

#6 2016-04-12 00:03:36

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,079
Website

Re: Write panel, reset time to now bug ?

philwareham wrote #298583:

This should be fixed in latest GitHub master – please test and let me know.

Yeah, the issue as specified now works correctly, the date / time are displayed correctly upon saving. However there is a new issue – but I’m not sure if I should blame you or Oleg (etc) for this.

  1. open an existing article
  2. observe the state of the sidebar (for ease of testing: all sub panels in the sidebar are closed/collapsed)
  3. edit the article – any type of editing will do
  4. save
  5. observe the state of the sidebar. On my Mac (tested with Safari and Firefox dev. edition), the “recent articles” sub panel is now open (and this can not be changed) and the “comment” sub panel is open, but the heading is not displayed.

Gonna file this on github as well… Opened an issue on github.

Last edited by phiw13 (2016-04-12 00:18:38)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#7 2016-04-12 06:40:12

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,079
Website

Re: Write panel, reset time to now bug ?

phiw13 wrote #298591:

Opened an issue on github.

Robert mostly fixed this, thank you.

However, I still see a small glitch in the Comment sub panel. After saving an existing article, there are 2 “Invitation” fields. As before, switching back-and-forth between views restores things to a sane state.

See screenshot attached to the Github issue linked above.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

Board footer

Powered by FluxBB