Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2008-11-20 12:05:01

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,271
Website GitHub

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

wet wrote:

Related to the $_POST contents of either article ‘ID’, article ‘Status’, dropdown ‘textile_body’, or dropdown ‘textile_excerpt’. Any plugins which might intervene?

The only ones I’m using that have any impact on the Articles tab are:

  • upm_savenew
  • glz_custom_fields
  • smd_tags

The latter hooks into the article edit step and reads the contents of the global ID like this:

if(!empty($GLOBALS['ID'])) { // newly-saved item
	$itemID = intval($GLOBALS['ID']);
} else {
	$itemID = (gps('ID')) ? gps('ID') : gps('id');
}

The next line checks if $itemID has some value. If it does, it updates the smd_tags / smd_tags_used tables to insert any tags that have been selected, then finishes and passes control back to TXP to continue the save. If $itemID is empty, it does nothing.

I can’t see anything that changes any of the global vars, it just reads them. In fact there’s no importing of any global var in my save function, just reading that $GLOBALS['ID'] once. Does that help at all?

Last edited by Bloke (2008-11-20 12:10:26)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#14 2008-11-20 12:12:59

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,323
Website Mastodon

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

Bloke wrote:

… list the articles, edit one and then sometimes I’ll get that message when I click Save.

  1. So it happens only when you save an article which already existed?
  2. Does this occur with all mentioned plugins disabled?
  3. Any traces in the web server’s error log?

Offline

#15 2008-11-20 12:34:52

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,271
Website GitHub

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

wet wrote:

So it happens only when you save an article which already existed?

Yes, seems to. And usually — but not always — it’s the first article I edit and save after logging in.

It’s only a very very occasional thing too, which is maddening. Wish I could replicate it. At least with something repeatable it’s easier to track down the culprit. If it’s just me and nobody else has seen anything like this, then I’ll ditch the site(s) that use the incremental SVNs and upload a clean copy of all the files from the package at the head of this post.

Does this occur with all mentioned plugins disabled?

Don’t know yet. Since it doesn’t occur every time anyway it’s difficult to know whether switching them off has any bearing or not. I can certainly run the site without those 3 for a time and see if it happens at all.

Any traces in the web server’s error log?

Sadly, no :-(

Last edited by Bloke (2008-11-20 12:35:11)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#16 2008-11-20 13:29:01

alanfluff
Member
From: Ottawa, Canada
Registered: 2008-09-15
Posts: 222
Website

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

All OK so far (but only a Vanilla install).

Only comment and likely I am missing something here, is that a default install points:

Prefs, Advanced, Temporary directory path

to

…/textpattern

I have innocently always thought it would be better pointing to:

…/textpattern/tmp

I’m sure there was logic behind it not going to /tmp but just in case, I thought to mention.

THANKS to all involved in making 4.0.7.


At LAST I’ve cheerfully donated to the core devs at #TXP. I only wish I were able to give more. Thanks to the devs and ALL fellow TXPers. -A

Offline

#17 2008-11-20 13:31:41

alanfluff
Member
From: Ottawa, Canada
Registered: 2008-09-15
Posts: 222
Website

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

Oh, and under ‘Diagnotics’ tab, I assume it is cool that the check is seeing all the new files are red scary modified files and this will be gone in final 4.0.7 — just mentioning in case.


At LAST I’ve cheerfully donated to the core devs at #TXP. I only wish I were able to give more. Thanks to the devs and ALL fellow TXPers. -A

Offline

#18 2008-11-20 14:06:04

kees-b
Member
From: middelburg, nl
Registered: 2004-03-03
Posts: 235
Website

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

Hi,

I found some missing localization strings:

Advanced preferences: smtp_from
Files tab after clicking ‘edit’ : replace_file

This last one is a strange one! I reported this allready with 4.0.6 but it was never updated. It is not missing in the english txp. When checking several lang files it actually is missing in some and not in others! Check nl-nl.txt where it is missing!

Admin CSS
When there are no comments, blocked IP’s, Links etc. The message saying so is aligned completely to the left: it should be centered.

kees

txp-nl

Offline

#19 2008-11-20 14:38:50

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,323
Website Mastodon

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

alanfluff wrote:

Prefs, Advanced, Temporary directory path to …/textpattern I have innocently always thought it would be better pointing to: …/textpattern/tmp

../textpattern/tmp is the usual and most desirable location. Any other value is the result of a fallback mechanism in case that either this directory does not exist or is not writeable. Please check your file system permissions to verify that the ../textpattern/tmp folder is writeable.

Offline

#20 2008-11-20 14:43:54

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,323
Website Mastodon

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

kees-b wrote:

Advanced preferences: smtp_from

Fixed.

When there are no comments, blocked IP’s, Links etc. The message saying so is aligned completely to the left: it should be centered.

Refresh your browser cache. Looks like your browser is using a stale style sheet.

Offline

#21 2008-11-20 14:53:54

kees-b
Member
From: middelburg, nl
Registered: 2004-03-03
Posts: 235
Website

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

wet wrote:

Advanced preferences: smtp_from
Fixed.

..and nl-localized

Refresh your browser cache. Looks like your browser is using a stale style sheet.

checked in several browsers and purged the browser cache but it it persists on the left

Last edited by kees-b (2008-11-20 14:56:53)

Offline

#22 2008-11-20 16:03:49

els
Moderator
From: The Netherlands
Registered: 2004-06-06
Posts: 7,458

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

kees-b wrote:

Admin CSS
When there are no comments, blocked IP’s, Links etc. The message saying so is aligned completely to the left: it should be centered.

Here too. Clearing the cache does not help. Note: this was not the case in r2992, so can it be a change that happened afterwards?

Offline

#23 2008-11-20 16:25:43

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,323
Website Mastodon

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

It’s a typo, fixed.

Last edited by wet (2008-11-21 20:38:26)

Offline

#24 2008-11-20 18:15:26

rsilletti
Moderator
From: Spokane WA
Registered: 2004-04-28
Posts: 707

Re: Feedback to: Help us test the release candidate for the upcoming 4.0.7

Gerhard – This is what I am currently testing:

ras_authors_list :Href list of authors
ras_delete_expired :Delete articles by expire field setting
ras_file_download_list :id list enabled file_download_list tag
ras_if_article_keywords :Article keywords matching conditional
ras_if_category_type :Conditional category (page search) tag that checks for category type
ras_if_dates :Conditional article content display control by posting time or date
ras_page_of :“Pages of Total” navigation
ras_plugin_credits :Plugin Author`s Credits

Offline

Board footer

Powered by FluxBB