Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2006-09-22 06:29:53

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

r1816+ Textile changes

Many incremental Textile improvements:

  • complex class/id/lang/style combinations work better
  • inline *markup* is less likely to get confused by stray characters
  • notextile and code are encoded and handled better
  • some cosmetic improvements, like special classes to identify footnotes and CAPS
  • links, images and inline markup work without surrounding whitespace, using square brackets: foo[*bar*]foo
  • ‘quote’ “glyphs” are now defined separately for each Textpattern translation
  • assorted bugfixes

A good way to test: edit an existing article. Preview it and check against the live article for differences. Post problems here.

Last edited by zem (2006-09-22 06:33:11)


Alex

Offline

#2 2006-09-22 16:05:21

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: r1816+ Textile changes

zem wrote:

  • notextile and code are encoded and handled better

Might this solve what I was experiencing here with a feed title?

Offline

#3 2006-09-23 00:10:54

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: r1816+ Textile changes

Textile isn’t used in titles, but I don’t really follow what you’re doing there. You tell me.


Alex

Offline

#4 2006-09-23 00:59:09

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: r1816+ Textile changes

From what Sencer explained to me about the parser, it does a second pass through the page.

If a feed title that comes through has a txp:tag, the parser on the second pass tries to execute it, thus nothing is gets output and it gives an error. My question was if could I wrap the output of the feeds in some kind of tag to tell the parser not to mess with it. Or else we need to change the plugin to properly escape txp:tags, which causes problems with other valid html tags.

http://simplepie.org/support/viewtopic.php?id=380

Last edited by hcgtv (2006-09-23 01:00:48)

Offline

#5 2006-09-23 01:21:51

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: r1816+ Textile changes

Textile and the parser are entirely separate. The parser is for <txp:...> tags.

Have you tested the Simplepie problem with feeds generated by recent txp svn revisions? It’s better at escaping feed output.

If you’d like the dev team to consider whether or not it’s a bug, we’ll need brief and specific examples.

Last edited by zem (2006-09-23 01:25:28)


Alex

Offline

#6 2006-09-23 01:51:44

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: r1816+ Textile changes

zem wrote:

Have you tested the Simplepie problem with feeds generated by recent txp svn revisions? It’s better at escaping feed output.

Yes, that’s where I encountered the error. I’m running the latest Textpattern and SimplePie code, fresh off the SVN servers.

I created a form that gets called from the default page template, it contains lines like this:
<code><txp:feed items=“10” showdesc=“false” alttitle=“Textpattern Forum” >http://forum.textpattern.com/extern.php?action=active&type=RSS</txp:feed>
</code>

When someone on this forum uses a txp:tag in the title of a post, that’s when the problems occur. This can also happen in the body of said post were I to display some text from it, like I do at the Textpattern Planet site.

What I’m experimenting with is being able to use Textpattern and SimplePie to create sites where I can display more of the feeds, sort of like the planet sites that litter the net, like the one at Textdrive.

Offline

#7 2006-09-23 02:08:22

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: r1816+ Textile changes

Oh, I see – it’s the punBB forum RSS feed that’s the trigger.

I’d say you’ve encountered one of many Catch 22’s in the RSS “spec”. There is no safe way to handle title elements (and possibly others) from arbitrary feeds without carefully escaping and/or stripping content.

At any rate, none of this relates to this thread.

Last edited by zem (2006-09-23 02:12:49)


Alex

Offline

#8 2006-09-23 05:08:49

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: r1816+ Textile changes

I understand now that what I’ve brought up doesn’t relate to this thread, but if we can have a notextile function, I can’t see why we can’t provide a noparser function also.

This would facilitate more than just bringing in feeds, it would allow us to embed anything we please into our sites without concern for instruction collisions.

Offline

#9 2006-09-23 22:31:27

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: r1816+ Textile changes

This would facilitate more than just bringing in feeds, it would allow us to embed anything we please into our sites without concern for instruction collisions.

Doing so is a security risk. If you’re letting raw txp or html tags through, you’re letting raw javascript through.

What’s the use case that demonstrates this as desired behaviour? (i.e. RSS contains x, resulting Textpattern page output should contain y)


Alex

Offline

#10 2006-09-23 22:52:08

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: r1816+ Textile changes

zem wrote:

Doing so is a security risk.

Ok.

Offline

Board footer

Powered by FluxBB