Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#25 2005-09-07 00:39:03

Sencer
Archived Developer
From: cgn, de
Registered: 2004-03-23
Posts: 1,803
Website

Re: Textpattern 4.0.1 Released

We have a txp-plugin list for plugin developers:
http://lists.textpattern.com/mailman/listinfo

there it has been discussed for a while already how to create exactly that with the help of a plugin. There is a callback you can use anda variable you can check, and then it’s only a matter of either including a page or doing whatever you want. People should not hack the code as it makes upgrading more difficult. A lot of things can be achieved by writing plugins, that should be your first choice.

There is also a list for people that are following development in svn (txp-dev), where we tried to get some feedback on some issues before the release. People interested in svn should probably subscribe.

Here it is explained how you can submit a patch:
http://forum.textpattern.com/viewtopic.php?id=6648

Offline

#26 2005-09-07 01:28:11

ramanan
Plugin Author
From: Toronto
Registered: 2004-03-12
Posts: 323
Website

Re: Textpattern 4.0.1 Released

Thanks for the info. I also think people shouldn’t hack the install. I’m still running 1.19 because it’s such a pain in the ass to move to the new version. If I figure out a good way to do what I did with my Hack using the new architecture in 4.0 I’ll let you guys know.

Offline

#27 2005-09-07 01:55:39

KurtRaschke
Plugin Author
Registered: 2004-05-16
Posts: 275

Re: Textpattern 4.0.1 Released

Caution, long-winded and now unnecessary rant follows. Please see my later post in this thread for the conclusion of this saga.

Sencer wrote:
We decided not to disclose any information until people have had sufficient time to update their installations.

And just how long exactly is “sufficient time”? If there’s been an announcement of “security fixes”, then anyone with enough time on their hands can go through the recent SVN changesets looking for something which could be exploited. Even if the commit message isn’t screaming “fixed vulnerable code here” (which they haven’t been recently), the diffs can still tell a lot. On a more practical note, though, if one has a production server running 4.0, one may not want to move to 4.0.1 without testing it first on a development server. Knowing the specific nature of the security fix would allow one to patch that specific issue in 4.0 without having to move to 4.0.1 without testing it first. That way the remainder of 4.0.1 could be tested at a later date, instead of under the pressure of trying to get a vulnerable server patched as quickly as possible.

Also, from a later post:

People should not hack the code as it makes upgrading more difficult.

Excuse me? Textpattern is an open-source project; people can do anything they want with the code, within the bounds of the GPL. My Textpattern install is pretty heavily-hacked, and guess what? It still runs just fine, and I just upgraded to 4.0.1 without a hitch. Sure, every once in a while I run into a conflict when I update to the latest SVN revision, and then I have to do some merging by hand, but hey, that’s what revision control is for. Now sure, if I break something, am I going to ask for help on the forums? Probably not. I’ll debug it myself, and try and replicate the problem on a ‘fresh’ TXP instance just checked out from the development sources. If I can still replicate it running off of the offical sources, then sure, I’ll report it on the forums.

So I can see a caveat telling people to stay off the forums unless they’re running an official release, but I can’t see telling them to stay out of the source, period. I can understand the idea that people with non-standard configurations shouldn’t take up the time of others while trying to troubleshoot problems that they may have brought on themselves. But a general admonition of hacking the code? To me, that’s just contrary to the whole idea of open-source. In a lot of other projects, the default response to a feature request is “Write a patch and send it in”, as where as with Textpattern it seems to be “It’s on the list to be done eventually, or you can write a plugin”.

I could see the logic behind that mentality if we were dealing with a very large, very fragile codebase which tended to break in nonintuitive ways, but truthfully Textpattern isn’t that big, and it doesn’t take very long to get up to speed on the internals of Textpattern.

Now, I’d like to make something clear. This isn’t meant to be a flame, but rather a constructive criticism of the Textpattern development process. Textpattern is a great piece of software, and I appreciate the work that everyone has put into it, but I do believe that certain changes might further improve the development process and improve relations between developers and users.

Finally, look at the Linux kernel. People hack the kernel to add functionality or fix bugs, they break things along the way, they ask for help on LKML, they fix the mess they’ve created, then they submit a patch. The patch goes in, and the cycle repeats itself.

I am not anti-plugin, but I do think that certain core functionality belongs in TXP proper. Additionally, if I’ve added the necessary code to one of my local TXP instances, it only takes a minute or two to release a diff of that code—”<code>svk diff</code>” makes it quite easy.

Yes, we do have callbacks and all that, but for a little one or two-liner fix I really don’t see how it’s worth the overhead of a plugin.

-Kurt

Last edited by KurtRaschke (2005-09-07 02:39:27)


kurt@kurtraschke.com

Offline

#28 2005-09-07 02:11:22

ramanan
Plugin Author
From: Toronto
Registered: 2004-03-12
Posts: 323
Website

Re: Textpattern 4.0.1 Released

I think you are reading way too much in to Sencer’s post. I think he was suggesting joe blow doesn’t hack his install up if he doesn’t know what he is doing. No more no less.

Offline

#29 2005-09-07 02:20:09

jdueck
Plugin Author
From: Minneapolis, MN
Registered: 2004-02-27
Posts: 147
Website

Re: Textpattern 4.0.1 Released

Excuse me? Textpattern is an open-source project; people can do anything they want with the code, within the bounds of the GPL.

Sencer didn’t say you weren’t allowed to hack the code, he just said people shouldn’t, since it makes things unnecessarily hard later on. You’re savvy enough to be able to mess around in the source (like I used to be when I had time); great for you. But you should also be savvy enough to know when general advice meant for typical users is being given.

So, you may consider yourself excused.

Offline

#30 2005-09-07 02:25:57

zem
Developer Emeritus
From: Melbourne, Australia
Registered: 2004-04-08
Posts: 2,579

Re: Textpattern 4.0.1 Released

I think he was suggesting joe blow doesn’t hack his install up if he doesn’t know what he is doing. No more no less.

Yes, precisely. Sencer is not a native English speaker (though his grasp of the language is often better than mine), and forum posts aren’t an ideal medium for subtle interpretations.

Textpattern is open source. By all means, hack away. But please plan ahead: running a modified version means you’ll have to port your modifications each upgrade. Writing modifications in plugin form usually makes this much easier. [also, we put quite a lot of effort into making sure that plugins can do almost anything. mods are usually an indication of something we’ve missed]


Alex

Offline

#31 2005-09-07 02:29:32

KurtRaschke
Plugin Author
Registered: 2004-05-16
Posts: 275

Re: Textpattern 4.0.1 Released

Well, in all honesty if I was reading too much in to Sencer’s post, then that’s a good thing. I knew at the time that most of what I was saying was overkill, but I wanted to get it out in the open now, rather than letting it fester.

I suppose I was just a bit put off at first by the way Sencer’s post was worded; it hit a nerve. It’s one thing to say that people who don’t know what they’re doing shouldn’t hack the code, but another thing to say that people in general shouldn’t hack the code. Yes, I probably should have noted the distinction and kept my mouth shut in the first place.

Edit, having seen zem’s post: Point taken. I’ll definitely agree that the forum is an imprecise medium and that I read into Sencer’s post far too much.

Sorry to have created such a fuss.

Now that I’ve made a fool of myself going on like this, why don’t we all get back to the real subject at hand?

-Kurt

Last edited by KurtRaschke (2005-09-07 02:35:00)


kurt@kurtraschke.com

Offline

#32 2005-09-07 03:13:11

1beb
Plugin Author
From: Canada, Ontario, Toronto
Registered: 2004-11-22
Posts: 169
Website

Re: Textpattern 4.0.1 Released

Now that I’ve made a fool of myself going on like this, why don’t we all get back to the real subject at hand?

Agreed.

Congrats on 4.01!

Offline

#33 2005-09-07 03:28:10

Hans
Member
From: Everywhere
Registered: 2004-03-07
Posts: 99
Website

Re: Textpattern 4.0.1 Released

Yeah, back on g1.16 my install was hacked beyond belief and it was a pain in the ass to upgrade to 1.17, 1.18, 1.19, then rc1,2,3. By rc3 all my hacks had become plugins made by someone else, and one TxP user graciously created a plugin for me before I could get a chance to hack away.

The big jump from rc3 to 4.0 broke some things in my links, structure etc. (but thankfully plugin-wise I was all right) and to this minute I still can’t figure out why my comment form doesn’t work. Not that I’m complaining…

Perhaps no one noticed my previous post, but I’ll ask again: What should I do if I install 4.0.1, yet the TxP interface and the Diagnostics tab say I still have 4.0? I’ve tried re-uploading everything a bunch of times, but nothing changes.

Last edited by Hans (2005-09-07 03:29:21)


Lumilux – A Photoblog

Offline

#34 2005-09-07 05:37:45

Vitruvius
Plugin Author
Registered: 2004-09-21
Posts: 125

Re: Textpattern 4.0.1 Released

Its great to see a new version so soon – as has been said “too much cheese is bairly enough…”

One question for anyone in the know: I note that Dean mentions very basic 404 support. What does this mean? Will I now get a proper 404 error when a page can’t be found – eg www.mysite.com.au/thispagedoesnotexist ?

Offline

#35 2005-09-07 06:38:39

Sencer
Archived Developer
From: cgn, de
Registered: 2004-03-23
Posts: 1,803
Website

Re: Textpattern 4.0.1 Released

Kurt, don’t worry, it happens to all of us sooner or later. ;) And yes what I meant was for people that are not sure how to upgrade. I’ve seen many people on other opensource projects that struggle with updates and put them off, because it was too much work or they didn’t even know how to do it without shooting themselves in the foot. And those are the people my message was directed to – as an advice only. :)

then anyone with enough time on their hands can go through the recent SVN changesets looking for something which could be exploited.

And that’s an order of magnitude less potential people, than if we published hot fixes. The 4.0.x releases will be structured such, that updates will be as painless as possible. On the txp-plugin as well as txp-dev list we asked for feedback on things that might break a few days before we released. (I suggest you join us there. :) ). It might well be possible that in a future issue, circumstances will force to to do what you suggested, but in this case we decided to move ahead as we did, because we think it it better for the majority of users.

Offline

#36 2005-09-08 11:57:33

zoeglingjulian
Member
From: London, UK
Registered: 2004-12-23
Posts: 52
Website

Re: Textpattern 4.0.1 Released

I don’t know if I missed it, but would you please write some words about small and subtle changes like the title="y" in the <txp:category1 /> tag the next time you change these things? I’ve been searching for hours why I didn’t get no more category titles ;)

And you forget to update the respective helper form under “usefull tags” next to the forms-edit-thing. Don’t wanna be nitpicking though because Textpattern is far too great to complain about anything.

Last edited by zoeglingjulian (2005-09-08 11:58:15)

Offline

Board footer

Powered by FluxBB