Login form in the plugin tab…

NicolasGraph · 2016-04-19 10:02:04

Hi, in 4.5.7 or 4.6, log you into your Txp admin; open two bowser tabs, each one tagerting your admin, one in the Admin>Plugin tab and logout from the other. Once you are log out, try to disable a plugin from the other browser tab… The login form appears in the plugin row.

Bloke · 2016-04-19 10:27:05

NicolasGraph wrote #298691:

Once you are log out, try to disable a plugin from the other browser tab… The login form appears in the plugin row.

That’s to do with the AJAX call failing because you’ve logged out. Perhaps we should only serve the login screen from non-asynchronous requests and silently fail otherwise. Anyone any view on this? Is that a better paradigm?

Incidentally, you also get error messages appearing in place of the Yes/No text if you try to enable a plugin that has syntax errors in it. And you’ll maybe get the login Form in many places on the Write panel if you log out in a different tab prior to saving an already published article. And in the Sections panel if you toggle any of the Yes/No options. Anywhere there’s AJAX, really.

etc · 2016-04-19 13:04:09

Bloke wrote #298692:

Perhaps we should only serve the login screen from non-asynchronous requests and silently fail otherwise. Anyone any view on this? Is that a better paradigm?

Silent fail can be misleading, probably js redirection is better?

Bloke · 2016-04-19 13:15:59

etc wrote #298695:

Silent fail can be misleading, probably js redirection is better?

Sure, if you can figure out how to do it, be my guest.

etc · 2016-04-19 14:39:05

Bloke wrote #298696:

Sure, if you can figure out how to do it, be my guest.

It could be just something like

if (!$txp_user) {
    if(ps('app_mode') == 'async') {
        echo '<script>window.location.assign("index.php")</script>';
        exit(0);
    } else {
        doLoginForm($message);
    }

in doAuth()?

NicolasGraph · 2016-04-20 05:59:26

Thanks for your replies; I can’t help to fix but I’ll keep watching this topic.

etc · 2016-04-22 12:16:00

Patched here, please test.

NicolasGraph · 2016-04-22 12:48:16

etc wrote #298770:

Patched here, please test.

Thanks, seems to work fine for now…

phiw13 · 2016-04-23 00:18:37

etc wrote #298770:

Patched here, please test.

Much better now. That is the behaviour I always would have expected.

etc · 2016-04-23 20:43:43

Thanks for testing, gentlemen. I was a little hesitating between js alert and confirm, it’s yet time to choose.

Textpattern CMS

Textpattern CMS support forum

#1 2016-04-19 10:02:04