Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#49 2011-12-17 04:08:53

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

If that thing above, posted by elwins, is from the plugin’s source code, I would not recommend using it. Seriously, you shouldn’t be using that in any situation. That code has some very serious security vulnerabilities.

Offline

#50 2011-12-17 05:32:36

elwins
Member
From: Latvia
Registered: 2011-08-29
Posts: 80

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

Its default code, only place what has changed is:

$lang = array(
		'section'           => 'forums',
		'reply_section'           => 'forums_replies',
		'category'           => 'category name is here..',
		'parent_custom_field'           => 'custom1',
	);

But I think, that some part of that code propobly is lost, because there was problems with posting it.

Offline

#51 2011-12-17 05:45:28

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

elwins wrote:

Its default code

In such case, I would advice uninstalling the plugin. It’s not safe to use.

Last edited by Gocom (2011-12-17 05:45:53)

Offline

#52 2011-12-17 08:22:30

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,269
Website GitHub

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

elwins

I’ve already donethe category thing, and more besides, in my (unreleased) modded version. I can’t remember how many of the security loopholes I closed offhand. Maybe some, maybe none — it was a loooong time ago I last looked at it. I’m due to revisit this over the next few weeks if you can wait a bit.

Gocom

In case you’re at a loose end over the holidays, could you please jot down some of the security issues and let me have them by e-mail. I can see a bunch of them in the code above (unescaped things, lack of doSlash(), etc) which I’ve probably caught already, but in case I missed any I’d appreciate your expertise on this. Thanks, man.

Last edited by Bloke (2011-12-17 08:23:00)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#53 2011-12-17 14:34:26

elwins
Member
From: Latvia
Registered: 2011-08-29
Posts: 80

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

Bloke wrote:

I’ve already donethe category thing, and more besides, in my (unreleased) modded version. I can’t remember how many of the security loopholes I closed offhand. Maybe some, maybe none — it was a loooong time ago I last looked at it. I’m due to revisit this over the next few weeks if you can wait a bit.

maybe you can give me now that category thing? I Just need to get visual side done, and then later, security side.

Last edited by elwins (2011-12-17 14:34:55)

Offline

#54 2011-12-18 16:22:34

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,269
Website GitHub

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

elwins wrote:

maybe you can give me now that category thing? I Just need to get visual side done, and then later, security side.

Not right now. I’m travelling and it’s at home. maybe when I get back.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#55 2011-12-18 19:00:06

elwins
Member
From: Latvia
Registered: 2011-08-29
Posts: 80

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

ok, when will you be back at home? :)

Offline

#56 2012-01-12 16:08:56

elwins
Member
From: Latvia
Registered: 2011-08-29
Posts: 80

Re: [plugin] [ORPHAN] TXPhorum 0.3 / A simple forum solution for Textpattern

Someone then can help me?

Offline

Board footer

Powered by FluxBB