Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#1 2016-04-22 13:55:32
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,304
Pref "Hide commenter email address"
Somebody who hasn’t changed their “Hide commenter email address” setting in 4.6, please have a quick look at it and post here: I’ve certainly not changed this pref, I’m on a fresh local test setup, i.e. no old inherited DB setting, no need to change that setting, but it’s set to “No” (i.e. reveal email address). It’s never been that way around, IIRC, and it’s also the unrecommended setting in the pophelp.
Last edited by uli (2016-04-23 13:11:44)
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
#2 2016-04-22 14:47:16
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,304
Re: Pref "Hide commenter email address"
If the setting comes from this line in admin_config.php, then I was mistaken, it’s been like that in several versions. Where I’m not wrong is: the default setting is not very privacy friendly. Is it still in accordance with EU law?
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
Re: Pref "Hide commenter email address"
It’s ‘No’ in 4.5.7, too. My best guess is that someone would have to explicitly use <txp:comment_email /> to display the address, and that’s not in the default theme.
That said, I wonder if that tag even works when the pref is set to ‘Yes’. Will test.
Offline
Re: Pref "Hide commenter email address"
Right. Hmm.
If <txp:comment_email /> is used in a comments form instance in 4.5.7, the email is shown regardless of whether the pref is set to ‘Yes’ or ‘No’.
Testing 4.6 next.
Offline
Re: Pref "Hide commenter email address"
Fresh 4.6-dev shows the preference set to ‘Yes’ – i.e., comment email address is hidden.
That said, adding <txp:comment_email /> to the comments form does still show the email, so I’m not 100% sure what this preference is actually supposed to do.
Offline
Re: Pref "Hide commenter email address"
Raised an issue: github.com/textpattern/textpattern/issues/677
Offline
Re: Pref "Hide commenter email address"
If I understand things correctly, that pref controls the output of <txp:comment_name /> —it displays the name of the commenter wrapped in a <a href=http://...> if that person has provided a URL or wrapped in a <a href=mailto:…> if the pref is set to NO (don’t hide) in the comments form. It you set the pref to YES (hide) then <txp:comment_name /> only outputs the name the commenter if no URL has been provided.
If you choose the explicitly use the <txp:comment_email /> tag to output the email address, you effectively override the preference.
That said, on my fairly recently set up, plain vanilla TXP 4.6 dev, the pref is set to YES (hide). Not sure what the meaning of the setting in admin_config.php as noted by Uli above. Is that another case where the value got mangled in 4.6, similarly to the issue with Use Textile pref I flagged see time ago?
Edit – grammar…
Last edited by phiw13 (2016-04-24 00:24:26)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Pref "Hide commenter email address"
phiw13 wrote #298790:
If you choose the explicitly use the
<txp:comment_email />tag to output the email address, you effectively override the preference.
Hmmm, must admit I’ve never used this tag, I’ve always used comment_name. The comment tags have changed quite a bit in 4.6 (they’re proper tags now, for starters) so this functionality could have slipped under the radar. But as far as I know it works the same as it always has. Whether that’s how it should work is up for debate. Anybody with any thoughts on what the tags should do is welcome to chime in.
Not sure what the meaning of the setting in
admin_config.phpas noted by Uli above.
Legacy crap. That file’s largely not used any more. Will be pruned one day to only include the privs.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: Pref "Hide commenter email address"
I respectfully stand corrected on this – thanks for the clarification, phiw13.
Offline
#10 2016-04-25 12:35:54
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,304
Re: Pref "Hide commenter email address"
Even better if there’s nothing wrong with the current initial setup.
Thanks for investigation on this issue!
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline