Textpattern Forum

You are not logged in. Register | Login | Help

#1 2012-06-28 01:07:17

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 613
Website

r3848 - edit plugin panel

Is there any reason why the contents of this panel isn’t wrapped in a div class="txp-edit" (inside the form)? It should just be consistent with all other edit panels.

Offline

#2 2012-06-28 07:32:19

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 1,625
Website

Re: r3848 - edit plugin panel

The reason was that txp-edit pane has a fixed width, which doesn’t lend itself well to the plugin editor. Also, since we are hoping to make edit panes modal in future, that one stood out as being the exception to the rule – makes no sense to have that editor as a modal.

Well, OK, import page is also an odd one out too.

Last edited by philwareham (2012-06-28 07:32:45)

Offline

#3 2012-06-28 09:04:22

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 613
Website

Re: r3848 - edit plugin panel

philwareham wrote:

The reason was that txp-edit pane has a fixed width, which doesn’t lend itself well to the plugin editor.

That is a weird reason. None of the edit panes have a fixed width in my theme… (a max-width yes). And I don’t see a reason to make it different for the edit plugin pane. It is just a textarea and a submit button, same semantics as other edit panes.
But whatever.
::shrug::

Also, since we are hoping to make edit panes modal in future, that one stood out as being the exception to the rule – makes no sense to have that editor as a modal.

Dunno, why not? Same semantics etc.

Offline

#4 2012-06-28 09:35:29

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 1,625
Website

Re: r3848 - edit plugin panel

The plugin editor was more akin to the style/form/page pages layout than the edit panes layout in my opinion.

Offline

#5 2012-06-28 10:39:34

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 6,000
Website

Re: r3848 - edit plugin panel

I don’t mind if it goes back into a txp-edit container, as long as there’s a CSS exception to make it wider, or the txp-edit container width is relaxed somehow to take the cols into account, which now define the textarea widths more consistently.

I guess it is an edit panel after all. And the fact that Classic has a fixed width doesn’t mean that other themes will. I’ll just do as I’m told on this one :-)

Last edited by Bloke (2012-06-28 10:39:43)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB