Textpattern CMS

#13 2009-11-13 22:54:28

els

Moderator

From: The Netherlands

Registered: 2004-06-06

Posts: 7,458

Re: taghandlers.php : remove hardcoded <br> tags

uli wrote:

If you specify a label tag it is not even applied/output although the attribute’s name suggests so

Uli, I don’t quite get it; there is no labeltag attribute, so I assume that is not what you meant?

#14 2009-11-13 23:14:38

uli

Moderator

From: Cologne

Registered: 2006-08-15

Posts: 4,304

Re: taghandlers.php : remove hardcoded <br> tags

Els wrote:

there is no labeltag attribute

Of course you’re right.

I think calling it “label” made me think the thing that’s named label here would be enclosed by labeltags, because otherwise I wouldn’t need an attribute, I could just write it in front of the form, semantically perfect or not. Small “but”, I know: It would be outside of the form then.

---

_{In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links}

#15 2009-11-24 06:03:08

TheEric

Plugin Author

From: Wyoming

Registered: 2004-09-17

Posts: 566

Re: taghandlers.php : remove hardcoded <br> tags

Bloke wrote:

fwiw I find the forced br a little annoying at times, especially when using the core’s ‘label’ feature in plugins. The alternative is to code the label stuff manually, but that adds bloat to plugins and using the core functionality is simpler (br notwithstanding).

So … I don’t know, remove three characters, “br.”?

Their should not be any markup that the user doesn’t explicitly specify.

#16 2009-11-24 06:20:22

wet

Developer Emeritus

From: Schoerfling, Austria

Registered: 2005-06-06

Posts: 3,323

Website Mastodon

Re: taghandlers.php : remove hardcoded <br> tags

Eric, the disutility of hard-coded markup in core tags is undisputed. This thread is currently revolving around suggestions on how to solve this in a backward-compatible, coherent manner.