Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#49 2018-06-20 15:41:36

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,011
Website GitHub Mastodon Twitter

Re: pat_speeder

Hi Patrick,

I started using your plugin and it rocks!!!
In the help file you mention:

code (optional): a comma separated list of tags name on which do not apply compression. Default: script,svg,code,pre

I did notice that when I have <!--googleoff: all--> the comment is stripped during parsing. Is there a way to keep html comments untouched when the plugin is enabled? ie could I use code="<!--"?


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#50 2018-06-20 17:17:21

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,599
GitHub Twitter

Re: pat_speeder

Hi Yannis ;)

I’m sorry, there no current possibilities except rewriting the plugin.


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#51 2018-06-20 21:43:00

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 4,596
Website

Re: pat_speeder

colak wrote #312652:

I did notice that when I have <!--googleoff: all--> the comment is stripped during parsing. Is there a way to keep html comments untouched when the plugin is enabled?

Pat64 wrote #312656:

I’m sorry, there no current possibilities except rewriting the plugin.

Yiannis, you could conceivably comment out this line which deals with removing comments. Or better, you could investigate a way of maintaining googleon and googleoff in the regex used.

But… it may not make sense anyway: I searched to see if someone had done that already and in the process discovered that the googleoff/googleon tags are of limited use anyway. Apparently – according to this stackoverflow thread and this google page – the tags only exclude content from the Google Search Appliance, e.g. the embeddable “search this site” widget, and do not have any effect on Google’s general web search results.


TXP Builders – finely-crafted code, design and txp

Offline

#52 2018-06-21 08:50:53

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,011
Website GitHub Mastodon Twitter

Re: pat_speeder

jakob wrote #312658:

Yiannis, you could conceivably comment out this line which deals with removing comments. Or better, you could investigate a way of maintaining googleon and googleoff in the regex used.

But… it may not make sense anyway: I searched to see if someone had done that already and in the process discovered that the googleoff/googleon tags are of limited use anyway. Apparently – according to this stackoverflow thread and this google page – the tags only exclude content from the Google Search Appliance, e.g. the embeddable “search this site” widget, and do not have any effect on Google’s general web search results.

Hi Julian,

Firstly thanks for the tip. It did the trick.

The google support doc is ambiguous to me. “Excluding Unwanted Text from the Index” could mean that it is not indexed by google and the all flag could mean all the above…

I just want to experiment with it for a few weeks to see if some content could be excluded from g’s search results.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#53 2018-06-21 13:49:33

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,599
GitHub Twitter

Re: pat_speeder

Hi you two ;)

If there are only <!--googleoff: all--> comment structures, I think it could be easy to allow such tag commenting with a REGEX.


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#54 2018-06-21 15:14:10

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,011
Website GitHub Mastodon Twitter

Re: pat_speeder

Hi Patrick, That would be wonderful as it would exclude all the other superfluous comments.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#55 2018-06-22 08:45:41

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,599
GitHub Twitter

Re: pat_speeder

Yiannis.

Sorry for my late answer but I never used these kind of google comments before and I can’t imagine what the purpose. Just for my curiosity, can you please tell me what the advantage?

If this is what you are looking for (kind of) in order to keep the type of commenting (can be multiline):

<!--googleoff: all--> Some hidden things for the GoogleBot <!--googleon: all-->

In this case, I’ve got the solution see a REGEX test here (included into the plugin code).

Please, tell me.

Last edited by Pat64 (2018-06-22 12:31:02)


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#56 2018-06-22 13:40:30

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,011
Website GitHub Mastodon Twitter

Re: pat_speeder

That did it… Thanks so much Patrick.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#57 2018-06-22 14:50:47

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,599
GitHub Twitter

Re: pat_speeder

Done. Available on the Github page.

Install, try and tell me more ;)

Note: it seems you have an error within your head part of your website:

<!--[if !IE]> </head>

Maybe it could be:

<!--[if !IE]><!-->
<html lang="en-gb">
<!--<![endif]-->
</head>

Note: I have updated the plugin for a much better support of IE conditional comments (tested successfully in TXP 4.7.0)

Last edited by Pat64 (2018-06-22 15:20:33)


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

#58 2018-06-22 16:42:50

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,011
Website GitHub Mastodon Twitter

Re: pat_speeder

Pat64 wrote #312680:

Done. Available on the Github page.

Install, try and tell me more ;)

Note: it seems you have an error within your head part of your website:

<!--[if !IE]> </head>

Maybe it could be:

<!--[if !IE]><!-->...

Note: I have updated the plugin for a much better support of IE conditional comments (tested successfully in TXP 4.7.0)

Thanks again Patrick. v0.7.5 solved all problems!!! Would this be a good time for v1?


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#59 2018-07-19 20:31:23

gilibaus
Member
From: Italy
Registered: 2013-08-14
Posts: 91
Website

Re: pat_speeder

Hi Patrick,
is v0.7.5 compatible with Textpattern 4.5.7?

Offline

#60 2018-07-20 10:48:11

Pat64
Plugin Author
From: France
Registered: 2005-12-12
Posts: 1,599
GitHub Twitter

Re: pat_speeder

Yep.


Patrick.

Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.

Offline

Board footer

Powered by FluxBB