Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#85 2006-10-13 17:04:08
- Mary
- Sock Enthusiast
- Registered: 2004-06-27
- Posts: 6,236
Re: Last pre-release: 4.0.4rc1
Thanks Greg. Try r1937.
Offline
Re: Last pre-release: 4.0.4rc1
I’m not on svn, so I’ll take your word for it, Mary, and see how it turns out next week. I’m glad I could help. :)
Offline
Re: Last pre-release: 4.0.4rc1
txp:newer and txp:older tags appear to support the ‘title’ attribute, but this is not documented and it doesn’t appear in the lAtts construct at the beginning of both functions, so no default value is set.
Offline
Re: Last pre-release: 4.0.4rc1
txp:category1, txp:category2, txp:category and txp:section tags are all Single_Tag according to documentation, but the code shows that they can be used as Container_Tag as well. However, the $thing that is contained, is not parsed, contrary to other Container Tags where this is usually done (right?).
Last edited by ruud (2006-10-13 21:36:10)
Offline
Re: Last pre-release: 4.0.4rc1
<a href=“http://dev.textpattern.com/browser/development/4.0/textpattern/publish/taghandlers.php?rev=1938#L1096”>line 1096</a> (link_to_next) of taghandlers.php should not parse $thing, because $thing is already parsed 4 lines earlier.
Compare it with the link_to_prev function, where it’s done correctly.
Offline
Re: Last pre-release: 4.0.4rc1
Two patches I posted to txp-dev (too late?):
october 11th: fixes html validation error in category edit page + more consistent styling of buttons
october 15th: attempt to fix some html/url encoding issues in taghandlers.php
r1939: I think comparing $thing to $next/prev_title works better if $thing is parsed before instead of afterwards (in the link_to_next and link_to_prev functions).
Offline
Re: Last pre-release: 4.0.4rc1
Quite a few things on the admin side of Textpattern aren’t HTML escaped. Patch sent to txp-dev.
Offline
Re: Last pre-release: 4.0.4rc1
There have been around 60 revisions in SVN since 4.0.4rc1… will there be a 4.0.4rc2?
Offline
Re: Last pre-release: 4.0.4rc1
ruud’s on fire. ;)
Offline
Re: Last pre-release: 4.0.4rc1
No, there were no majorly critical things in the last rc, and most changes should not have had far-reaching effects. We’re mor or less ready to release. 1948 is probably going to be it.
I am in #textpattern (on freenode) availabe for chat regarding any last minute stuff.
Offline
Re: Last pre-release: 4.0.4rc1
Ok, still need to review some odd stuff that turned up in regression tests, it’s probably a false aarm, but we’ll wait with the release for tomorrow just to be sure.
Offline